Solution for browser tests outside of //chrome?

3 views
Skip to first unread message

Avi Drissman

unread,
Dec 11, 2024, 11:10:40 AM12/11/24
to content-owners
For browser tests outside of //chrome, we basically have them reuse the content browsertest classes. Specifically, the content API has https://source.chromium.org/chromium/chromium/src/+/main:content/public/test/content_browser_test.h.

However, that uses things like Shell, which means that just about every non-trivial browsertest has to specially DEPS in //content/shell.


Running this by you folks, but if we want to expose content::ContentBrowserTest in the content API, we should also expose enough of the pieces to let it be fully used without having to bypass the API.

Avi

Avi Drissman

unread,
Dec 11, 2024, 11:40:20 AM12/11/24
to content-owners

Avi Drissman

unread,
Dec 18, 2024, 1:37:20 PM12/18/24
to content-owners
The other aspect that's weird is that Content Shell is an embedder of content/. content/'s API is content/public, and Content Shell's API is content/public/test, so even content, in its tests, should be accessing Content Shell via content/public/test.

Avi

Avi Drissman

unread,
Dec 18, 2024, 3:20:00 PM12/18/24
to content-owners
Does anyone have context on content/web_test? That seems to be very intimately familiar with content shell, and I suppose it needs to go through content/public/test too.

Avi Drissman

unread,
Dec 19, 2024, 10:49:55 AM12/19/24
to content-owners
I'm trying to get my head around the dependencies. My CL is https://crrev.com/c/6105882 wherein I'm trying to put shell.h into the testing public API and have a shell_impl.h implementing it, but looking at content/BUILD.gn is giving me a headache. Does anyone have advice here?

Avi
Reply all
Reply to author
Forward
0 new messages