network::RendererProcess

[Christopher Staite]

Hi all,

In https://crrrev.com/c/7498491 I made network::RendererProcess, but as I’ve been using it in https://crrev.com/c/7269607 it was pointed out that my naming was a little off.

The suggestion is to rename this network::RendererProcess -> network::RendererProcessId.  Not only does this mirror content::ChildProcessId, it also avoids the confusion of what it is.

Before I went ahead and did a refactor again on all those recently changed files, I thought I’d send a quick email to check this was a generally supported move.

While at it, I’d probably change network::OriginatingProcess -> network::OriginatingProcessId, but this is a little more contentious as it’s a union.  However, it’s still essentially just an ID under the hood.

As with all software, naming things is the hardest thing.

Thanks, Chris.

[Kenichi Ishibashi]

Hi Christopher,

The suggestion makes sense to me.

Thanks,