Fwd: [chromium-dev] PSA: OWNERS Reviews being Removed for DEPS "include_rules" Additions

[danakj]

FYI as this is the primary way content layering is preserved

---------- Forwarded message ---------
From: Andrew Grieve <agr...@chromium.org>
Date: Thu, Oct 10, 2024 at 3:28 PM
Subject: [chromium-dev] PSA: OWNERS Reviews being Removed for DEPS "include_rules" Additions
To: chromium-dev <chromi...@chromium.org>

You currently need to get an OWNERS approval for paths that you add to a DEPS's "include_rules" list. This sometimes makes sense, but is more commonly just a rubber stamp review.

In order to reduce the number of these low-value reviews, I'd like to change the default behavior to not require an OWNERS review for additions to "include_rules" (crbug).

No review will be required by default, but directories can opt in. For example:

If //base/DEPS contains:

new_usages_require_review = True

Then a CL that added:

include_rules = [ "+base/foo/bar" ]

Would require a review from a //base OWNER

Action required:

To opt-in to needing reviews, please add new_usages_require_review = True to your DEPS files.

I'll plan to switch the default on October 24 (two weeks) to give everyone time to add the line, or to shout and convince me this is a terrible idea :P

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABiQX1UbNvrje4GYcHEECVeoQdtWCxwhY___7RDF9PkL8XjrAQ%40mail.gmail.com.

[Charlie Reis]

Thanks for noticing!  Fortunately, dtapuska@ already landed https://chromium-review.googlesource.com/c/chromium/src/+/5924517 for making sure new dependencies on //content are reviewed.  (Thanks Dave!)

Charlie

You received this message because you are subscribed to the Google Groups "content-owners" group.
To unsubscribe from this group and stop receiving emails from it, send an email to content-owner...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/CAHtyhaQuFaWHHvkv1FzcJ2TZ4k%2BpggLy_q1AVmYL5-m2snZ4WA%40mail.gmail.com.