Plumbing NavigationHandle in WebContents::OpenURL.

245 views
Skip to first unread message

Arthur Sonzogni

unread,
Mar 4, 2024, 3:55:38 PM3/4/24
to content-owners, Huanpo Lin, Hiroki Nakagawa, Takashi Toyoshima
Hi @content-owners:

@robertlin just published a doc (@google) asking about adding a new API to content/. I will take a closer look tomorrow (initial thoughts), but I'd be curious to share it here and see if someone is interested about this question.

This is about the general need for embedders to associate data to navigation.
We already expose the NavigationHandleUserData for this use case, and several navigation API returning the NavigationHandle to consume: Either via its return value (e.g. LoadURL), or via a callback params (e.g. StartPrerendering). However there are none for the more general OpenURL API creating both the WebContent and the navigation.

John Abd-El-Malek

unread,
Mar 4, 2024, 5:04:45 PM3/4/24
to Arthur Sonzogni, content-owners, Huanpo Lin, Hiroki Nakagawa, Takashi Toyoshima
I've had the need many years ago to do this (attach data to NavigationHandle) in this call and had to hack around it. It doesn't look like NH creation can be made synchronous always, so +1 to adding a callback parameter (and don't need to change the params struct even).


--
You received this message because you are subscribed to the Google Groups "content-owners" group.
To unsubscribe from this group and stop receiving emails from it, send an email to content-owner...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/6ab00c3d-b7aa-401c-93d9-d638a2ddecfcn%40chromium.org.

Huanpo Lin

unread,
Mar 6, 2024, 3:45:36 AM3/6/24
to John Abd-El-Malek, Arthur Sonzogni, content-owners, Hiroki Nakagawa, Takashi Toyoshima
Thanks for the feedback.
It seems that the option 4: adding a callback parameter is supported by the active reviewers in this thread (jam@, arthursonzogni@, toyoshim@)
And the option will help more in the long run, so please allow me to proceed with the option.
If you have any other concerns or feedback, please let us know in this thread or in the document.
Reply all
Reply to author
Forward
0 new messages