Re: Adding a11y owners to content/public/browser/OWNERS

[Nasko Oskov]

Switching over to content...@chromium.org in order to get other folks in the discussion.

On Mon, 3 Mar 2025 at 16:20, Aaron Leventhal wrote:

Hi Nasko,

Following up on this, would it be reasonable to add a line to

content/public/browser/OWNERS

Something like:

per-file browser_accessibility_state.h=file://ui/accessibility/OWNERS

Or we could list specific individuals.

I would be comfortable starting with specific people, as they will have to familiarize themselves with the //content/ API guidelines and restrictions. Adding a different OWNERS file which has no such expectation has the potential to cause misunderstandings. 

 

This file needs a little cleanup. It grew organically and has plenty of debt. 

Could we use this cleanup as an opportunity to both reduce the tech debt and to demonstrate familiarity with the public API guidelines? 

 

WDYT?

In general, it seems like a reasonable thing to do. I'd like to hear what other content owners think.

 

Thanks,

Aaron

[Rakina Zata Amni]

Just want to chime in that Nasko's plan to add specific people as specific file owners sounds good to me :) We do want to know that the added owners are familiar with the guidelines even if they only review specific/AX files.

--
You received this message because you are subscribed to the Google Groups "content-owners" group.
To unsubscribe from this group and stop receiving emails from it, send an email to content-owner...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/CAA%3DmyAvWtpnnJi9%3DE%2BZSwD_EardGEcQvXf4pbpujRsNcMUk6wg%40mail.gmail.com.

[Nasko Oskov]

On Thu, 6 Mar 2025 at 12:51, Aaron Leventhal <aleve...@chromium.org> wrote:

Hi, we are ok with the plan. The nominees are:

- Myself — I've read the guidelines and they seem reasonable.

- David Tseng, "Yup; can do that and yeah, I'm picky enough or got picked on enough in the past to know about those guidelines 😛"

- Greg Thompson, ack'd the guidelines and noted that he's really picky about clean code (in my experience he makes great suggestions for cleaning stuff up).

- Ben Beaudry from Microsoft, I haven't received an ack from him yet. He's CC'd.

Thanks!

 

Here's a CL to add us to owners; however, it sounds like you wanted to gate this on us demonstrating familiarity with the API guidelines (you wrote "Could we use this cleanup as an opportunity to both reduce the tech debt and to demonstrate familiarity with the public API guidelines? "). You basically just want a few more CLs from some of us first?

Yes, a few CLs would be great. We usually do a shadowing step, where folks review the CL and an owner looks it over afterwards and person is added after there is reasonable demonstration of good practices. Given the smaller scope here, I'm happy to do the inverse - land the CL, but cc myself or one of the other content/OWNERS folks on a few non-trivial CLs. Does that sound reasonable?

 

- Aaron

[Aaron Leventhal]

Yes, that's totally reasonable. Thank you. I'll make sure to get an acknowledgement from each owner on that.

[Aaron Leventhal]

Hi, we are ok with the plan. The nominees are:

- Myself — I've read the guidelines and they seem reasonable.

- David Tseng, "Yup; can do that and yeah, I'm picky enough or got picked on enough in the past to know about those guidelines 😛"

- Greg Thompson, ack'd the guidelines and noted that he's really picky about clean code (in my experience he makes great suggestions for cleaning stuff up).

- Ben Beaudry from Microsoft, I haven't received an ack from him yet. He's CC'd.

Here's a CL to add us to owners; however, it sounds like you wanted to gate this on us demonstrating familiarity with the API guidelines (you wrote "Could we use this cleanup as an opportunity to both reduce the tech debt and to demonstrate familiarity with the public API guidelines? "). You basically just want a few more CLs from some of us first?

- Aaron

On Mon, Mar 3, 2025 at 7:35 PM Nasko Oskov <na...@chromium.org> wrote: