Time to kill WebContentsGetter?

227 views
Skip to first unread message

Avi Drissman

unread,
Jan 18, 2024, 10:58:29 PM1/18/24
to content-owners
There aren't too many instances left.

I think this was from a time when we had to convey WebContentses across trips to the IO thread, but I don't think that the IO thread is much of a thing any more, and nowadays you can make a weak pointer to a WebContents so keeping a getter around as a pseudo-weak pointer doesn't make much sense.

Avi

Avi Drissman

unread,
Jan 18, 2024, 11:05:14 PM1/18/24
to content-owners
Huh, I think I was inspired by seeing something about the Getter fly past my review stream, but it seems that was Erik, who added a warning with https://chromium-review.googlesource.com/c/chromium/src/+/5190999 .

Is this a general consensus? You have my buy-in, but I don't see a bug, which would be nice to use to track. In addition, uses are still being added (https://chromium-review.googlesource.com/c/chromium/src/+/4709689).
Reply all
Reply to author
Forward
0 new messages