About content/browser dependency on absl library

[Addison Luh]

Hi Content owners,

I have a change that would like to use the absl::flat_hash_map class in a target under content/browser/accessibility.  I see that absl in general is not explicitly included in //content/browser/DEPS.  That file says to email here before adding a new dependency.  I'm planning to add "third_party/abseil-cpp" to it.  Please let me know if it's ok to add it, or is there some special reason that it's not there?  FWIW, from doing a `gn desc`, I see that that library is already an indirect dependency.  Thanks!

Addison

[Dave Tapuska]

absl is allowed by default at the base. See https://source.chromium.org/chromium/chromium/src/+/main:DEPS;l=4962?q=DEPS&ss=chromium%2Fchromium%2Fsrc

I'm not sure why you'd need something specific in content/browser/accessibility. Are you getting an error?

dave.

--
You received this message because you are subscribed to the Google Groups "content-owners" group.
To unsubscribe from this group and stop receiving emails from it, send an email to content-owner...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/CACZcAi1RxnQMor7NS_Fc6BkkbhuW1huhma7ob8PSggSNf%3D%2BQ-A%40mail.gmail.com.

[Addison Luh]

Thanks for the fast response.  I realized that vscode's auto complete included the file from the wrong directory.  It included "absl/container/flat_hash_map.h" instead of "third_party/abseil-cpp/absl/container/flat_hash_map.h". 🤦  Sorry for the noise!

Addison

[Avi Drissman]

No worries, we've all gotten bitten by that auto-include feature of VSCode. It's awesome until it isn't.

Avi

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/CACZcAi17zXP2OZgY0kk233efmXtJfmo%3DgedRfKXEEVDEsi%3D_8g%40mail.gmail.com.