Crashes in _llvm_profile_write_file on bots

[Daniel Cheng]

Hi all,

I'm trying to merge a patch to M83: https://chromium-review.googlesource.com/c/chromium/src/+/2158012

But it's failing on the bots. The failure appears to be when we're writing out the profile at exit:

[ RUN      ] All/ConfirmCleanupSilentMainDialogTest.ConfirmCleanup/TextFile
[       OK ] All/ConfirmCleanupSilentMainDialogTest.ConfirmCleanup/TextFile (16 ms)
[----------] 1 test from All/ConfirmCleanupSilentMainDialogTest (16 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (17 ms total)
[  PASSED  ] 1 test.
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
__llvm_profile_merge_from_buffer [0x00007FF62BCB1160+256] (C:\b\s\w\ir\cache\builder\src\third_party\llvm\compiler-rt\lib\profile\InstrProfilingMerge.c:116)
__llvm_profile_write_file [0x00007FF62BC85FCB+699] (C:\b\s\w\ir\cache\builder\src\third_party\llvm\compiler-rt\lib\profile\InstrProfilingFile.c:1046)
<lambda_f03950bc5685219e0bcd2087efbe011e>::operator() [0x00007FF62BD205BF+139] (o:\fake\prefix\minkernel\crts\ucrt\src\appcrt\startup\onexit.cpp:206)
__crt_seh_guarded_call<int>::operator()<<lambda_7777bce6b2f8c936911f934f8298dc43>,<lambda_f03950bc5685219e0bcd2087efbe011e> &,<lambda_3883c3dff614d5e0c5f61bb1ac94921c> > [0x00007FF62BD206AD+37] (o:\fake\prefix\vccrt\vcruntime\inc\internal_shared.h:204)
_execute_onexit_table [0x00007FF62BD2036D+53] (o:\fake\prefix\minkernel\crts\ucrt\src\appcrt\startup\onexit.cpp:231)
<lambda_6e4b09c48022b2350581041d5f6b0c4c>::operator() [0x00007FF62BD1DDCB+111] (o:\fake\prefix\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:232)
__crt_seh_guarded_call<void>::operator()<<lambda_d80eeec6fff315bfe5c115232f3240e3>,<lambda_6e4b09c48022b2350581041d5f6b0c4c> &,<lambda_2358e3775559c9db80273638284d5e45> > [0x00007FF62BD1DE45+37] (o:\fake\prefix\vccrt\vcruntime\inc\internal_shared.h:224)
common_exit [0x00007FF62BD1DD43+163] (o:\fake\prefix\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:278)
__scrt_common_main_seh [0x00007FF62BD1175F+371] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:295)
BaseThreadInitThunk [0x00007FFF18692774+20]
RtlUserThreadStart [0x00007FFF18B80D51+33]

(from https://chromium-swarm.appspot.com/task?id=4bb6edbeeb316610)

Any idea what's going on here? I'm pretty sure it shouldn't be related to my patch, but it's also blocking it from landing.

Daniel

[Nico Weber]

Is this https://bugs.chromium.org/p/chromium/issues/detail?id=1071664 , or related to it?

I'm surprised this runs on the linux-rel bot though -- as far as I understand, it's not supposed to run there.

...ah, it's for coverage: https://source.chromium.org/chromium/chromium/tools/build/+/master:scripts/slave/recipe_modules/code_coverage/api.py;l=208?q=%22ensure%20profdata%20dir%22&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2Fsearch%2F

We probably don't need coverage information on the branch builders (?) so we should probably turn it off there. But it shouldn't crash either. So probably file two bugs, one for turning off coverage instrumentation for branch cq jobs, and one for the crash, and give them both to sajjadm for starters I'd say.

--
To unsubscribe from this group and stop receiving emails from it, send an email to clang+un...@chromium.org.