Re: request: merge LLVM /guard:cf option patch into old chromium LLVM toolset

[Hans Wennborg]

> #define CHROME_VERSION_MAJOR 104

That is a pretty old version, from 2022 I believe.

I'm not really familiar with CEF. Does it build with Chromium's regular toolchain, or does it allow you to bring your own?

If the old CEF can be built with trunk Clang, I'd suggest trying that first. If not, I'd suggest applying the PR on top of the Clang version that Chromium used at the time (3f3a235aa2e610b5ba393228a666d55a8135ef4a) and using that.

Thanks,

Hans

On Wed, Nov 5, 2025 at 3:23 PM Cheng Yang <che...@qti.qualcomm.com> wrote:

Hi @ha...@chromium.org,

I work at Qualcomm China, and we are currently attempting to build the CEF project for the ARM64EC architecture. However, we encountered an issue with LLVM CFG that has already been resolved in this ticket: [CodeGen][ARM64EC] Don't treat guest exit thunks as indirect calls by cjacek · Pull Request #165885 · llvm/llvm-project.

You can find more details about the issue here: [ARM64EC] The crash related to '/gaurd:cf' when protecting assembly implemented function. · Issue #165504 · llvm/llvm-project.

As we are approaching a project deadline, could you please check the fixed patch mentioned above and apply it to the old chromium LLVM toolset? Additionally, is it feasible to apply patches to the old chromium LLVM toolset?

Thank you for your assistance.

The chromium version is as follow:
#define CHROME_VERSION_MAJOR 104

#define CHROME_VERSION_MINOR 0

#define CHROME_VERSION_BUILD 5112

#define CHROME_VERSION_PATCH 102

BRs,

Cheng Yang

[Cheng Yang]

[Yufei Yuan]

++

 

From: Hans Wennborg <ha...@chromium.org>
Sent: Thursday, November 6, 2025 12:55 AM
To: Cheng Yang <che...@qti.qualcomm.com>
Cc: cl...@chromium.org; Changgeng Zhong <chan...@qti.qualcomm.com>; Zhanwei Wu <zhan...@qti.qualcomm.com>; Weidong Feng <weid...@qti.qualcomm.com>; Yufei Yuan <yuf...@qti.qualcomm.com>; Sai Xu <sa...@qti.qualcomm.com>; Hao Zeng <hao...@qti.qualcomm.com>; Petter Larsson <plar...@quicinc.com>; Eli Friedman <efri...@quicinc.com>
Subject: Re: request: merge LLVM /guard:cf option patch into old chromium LLVM toolset

 

CAUTION: This email originated from a known Qualcomm vendor. Please exercise caution with any unexpected requests, links, or attachments.

[Cheng Yang]

Hi @Hans Wennborg,

Thank you for your kind advice. I'm currently attempting to build the latest main branch with CFG patch.

BRs,

Cheng Yang

---

From: Yufei Yuan <yuf...@qti.qualcomm.com>
Sent: Thursday, November 6, 2025 09:29
To: Hans Wennborg <ha...@chromium.org>; Cheng Yang <che...@qti.qualcomm.com>
Cc: cl...@chromium.org <cl...@chromium.org>; Changgeng Zhong <chan...@qti.qualcomm.com>; Zhanwei Wu <zhan...@qti.qualcomm.com>; Weidong Feng <weid...@qti.qualcomm.com>; Sai Xu <sa...@qti.qualcomm.com>; Hao Zeng <hao...@qti.qualcomm.com>; Petter Larsson <plar...@quicinc.com>; Eli Friedman <efri...@quicinc.com>; Gaurav Goel <gg...@qti.qualcomm.com>; Vishnu Vardhan Kasiliya Sudarsan <vkas...@qti.qualcomm.com>
Subject: RE: request: merge LLVM /guard:cf option patch into old chromium LLVM toolset