Whitelist prod URL for Chrome Remote Desktop. [chromium/src : master]

Jamie Walch (Gerrit)

unread,

Aug 14, 2017, 4:52:45 PM8/14/17

to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

PTAL.

View Change

To view, visit change 614362. To unsubscribe, or for help writing mail filters, visit settings.

Joe Downing (Gerrit)

unread,

Aug 14, 2017, 5:43:56 PM8/14/17

to Jamie Walch, chromium...@chromium.org, chromotin...@chromium.org

View Change

1 comment:

File remoting/webapp/crd/manifest.json.jinja2:
- Patch Set #1, Line 74: *
  nit: we could scope this to the 'access' pages as discussed. Adding this note for context when we pick this back up.

To view, visit change 614362. To unsubscribe, or for help writing mail filters, visit settings.

Jamie Walch (Gerrit)

unread,

Aug 29, 2017, 7:23:31 PM8/29/17

to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

PTAL

View Change

1 comment:

File remoting/webapp/crd/manifest.json.jinja2:

- Patch Set #1, Line 74: *

- nit: we could scope this to the 'access' pages as discussed. […]
  Thinking about this some more, I don't think this buys us anything in terms of security, and requires an otherwise unnecessary app release if we change our URL structure. I don't think it's worth locking it down more than this.

To view, visit change 614362. To unsubscribe, or for help writing mail filters, visit settings.

Joe Downing (Gerrit)

unread,

Aug 29, 2017, 7:25:53 PM8/29/17

to Jamie Walch, chromium...@chromium.org, chromotin...@chromium.org

Patch set 1:Code-Review +1

View Change

1 comment:

File remoting/webapp/crd/manifest.json.jinja2:

- Patch Set #1, Line 74: *

- Thinking about this some more, I don't think this buys us anything in terms of security, and require […]
  SGTM

To view, visit change 614362. To unsubscribe, or for help writing mail filters, visit settings.

Jamie Walch (Gerrit)

unread,

Aug 29, 2017, 7:35:18 PM8/29/17

to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

Patch set 1:Commit-Queue +2

View Change

To view, visit change 614362. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 29, 2017, 8:36:29 PM8/29/17

to Jamie Walch, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Joe Downing: Looks good to me
  Jamie Walch: Commit

Whitelist prod URL for Chrome Remote Desktop.

Bug: b/64362070
Change-Id: Iaf5f1079d75a140b4fc2aab33eec6336798f8f03
Reviewed-on: https://chromium-review.googlesource.com/614362
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Jamie Walch <jamie...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498309}
---
M remoting/webapp/crd/manifest.json.jinja2
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/remoting/webapp/crd/manifest.json.jinja2 b/remoting/webapp/crd/manifest.json.jinja2
index aa094bc..fe97207 100644
--- a/remoting/webapp/crd/manifest.json.jinja2
+++ b/remoting/webapp/crd/manifest.json.jinja2
@@ -71,6 +71,7 @@
   },
   "externally_connectable": {
     "matches": [
+      "https://remotedesktop.google.com/*"
     ]
   }
 }

To view, visit change 614362. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward