[remoting] Rename base_export.h to remoting_export.h and replace host_export.h [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 31, 2026, 12:18:57 PM (3 days ago) Mar 31
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 31, 2026, 2:31:04 PM (3 days ago) Mar 31
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 31, 2026, 2:35:15 PM (3 days ago) Mar 31
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 31, 2026, 2:39:00 PM (3 days ago) Mar 31
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[remoting] Rename base_export.h to remoting_export.h and replace host_export.h
This CL consolidates the export macros in the remoting codebase.
Specifically:
1. Renames remoting/base/base_export.h to remoting/base/remoting_export.h.
2. Replaces REMOTING_BASE_EXPORT and HOST_EXPORT with REMOTING_EXPORT.
3. Removes remoting/host/host_export.h.
4. Updates all includes and build files to use the new header and macro.
This simplifies the export logic and allows sharing the same macro
across base and host components.
Change-Id: Ic7ce1f19f8ff85465a084d77578a3cac24e998be
Auto-Submit: Joe Downing <joe...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607993}
Files:
- M remoting/base/BUILD.gn
- R remoting/base/remoting_export.h
- M remoting/base/security_key_socket_name.h
- M remoting/build/config/BUILD.gn
- M remoting/docs/architecture.md
- M remoting/host/BUILD.gn
- M remoting/host/crash/crash_uploader_main.h
- D remoting/host/host_export.h
- M remoting/host/host_main.h
- M remoting/host/it2me/it2me_native_messaging_host_main.h
- M remoting/host/linux/remote_session_info_main.h
- M remoting/host/mac/agent_process_broker_main.h
- M remoting/host/mac/host_service_main.h
- M remoting/host/remote_open_url/remote_open_url_main.h
- M remoting/host/security_key/remote_security_key_main.h
- M remoting/host/setup/me2me_native_messaging_host_main.h
- M remoting/host/setup/start_host_main.h
- M remoting/host/webauthn/remote_webauthn_main.h
Change size: M
Delta: 18 files changed, 40 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages