More MAGI fat trimming [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
May 19, 2026, 2:12:17 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Joe Downing added 4 comments![]( "Open in Gerrit")
File remoting/tools/magi-mode/PRESUBMIT.py
Line 564, Patchset 1 (Latest):
proj_content = project_content_cache.get(project_file_path, {})Joe Downing . unresolved
Please fix this WARNING reported by autoreview issue finding: Since `paranoia_mode` and `auditability_level` were removed from the JSON schemas and checking logic below, `proj_content` is no longer used. The entire block from lines 534 to 564 for cross-file validation of `state_transport` is now dead code and should be removed.
Line 590, Patchset 1 (Latest):
if 'repo_type' not in environment:Joe Downing . unresolved
Please fix this WARNING reported by autoreview issue finding: `output_directory` was added to the `required` list of `EnvironmentDef` in `magi_schema.json`. However, `_ValidateSchema` does not recursively validate nested objects or resolve `$ref`. You should add an explicit check here to ensure `output_directory` is present, just like you do for `repo_type`.
File remoting/tools/magi-mode/PRESUBMIT_test.py
Line 552, Patchset 1 (Latest):
'"goal", "target_files", "anti_goals", "edge_cases", "next_stage"], 'Joe Downing . unresolved
Please fix this WARNING reported by autoreview issue finding: The mock schema here still lists `"anti_goals"` and `"edge_cases"` as required for `ProjectSpec`, but they were removed from the actual `magi_schema.json` in this change. Consider removing them here as well for consistency.
File remoting/tools/magi-mode/SKILL.md
Line 422, Patchset 1 (Latest):
arguments of `invoke_subagent` tool calls. *Joining Rule:*\* If a mandate orJoe Downing . unresolved
Please fix this WARNING reported by autoreview issue finding: There is a typo here: `*\*`. It should probably just be `*` for the markdown italics.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:16:36 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:17:07 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:18:43 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Joe Downing abandoned this change.
Abandoned
Joe Downing abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:18:44 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Joe Downing abandoned this change.
Abandoned
Joe Downing abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:18:47 PM (2 days ago) May 19
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Joe Downing abandoned this change.
Abandoned
Joe Downing abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:18:51 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Joe Downing abandoned this change.
Abandoned
Joe Downing abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 3:20:37 PM (2 days ago) May 19
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Joe Downing abandoned this change.
Abandoned
Joe Downing abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 7:11:20 PM (2 days ago) May 19
to Yuwei Huang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
May 19, 2026, 7:20:55 PM (2 days ago) May 19
to Joe Downing, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 19, 2026, 8:06:29 PM (2 days ago) May 19
to Joe Downing, Yuwei Huang, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
More MAGI fat trimming
Removing some vestigial and low-value features to further
streamline the process and reduce the likelihood of
hallucinations.
Change-Id: I2279471fd048c9004a5921160b9070480f1e2132
Auto-Submit: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633207}
Files:
- M remoting/tools/magi-mode/EXAMPLES.md
- M remoting/tools/magi-mode/PRESUBMIT.py
- M remoting/tools/magi-mode/PRESUBMIT_test.py
- M remoting/tools/magi-mode/ROUTING.md
- M remoting/tools/magi-mode/SKILL.md
- M remoting/tools/magi-mode/magi_schema.json
- A remoting/tools/magi-mode/personas/core/auditor.json
- R remoting/tools/magi-mode/personas/core/implementation.json
- M remoting/tools/magi-mode/tests/testdata/project.magi.json
- M remoting/tools/magi-mode/tests/testdata/state_block.magi.json
Change size: L
Delta: 10 files changed, 149 insertions(+), 307 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages