remoting: Refactor security key pipeline to support multiple transports [chromium/src : main]

0 views

Skip to first unread message

Yuwei Huang (Gerrit)

unread,

Jun 24, 2026, 10:41:56 PM (5 days ago) Jun 24

to chromium...@chromium.org, chromotin...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Yuwei Huang added 2 comments

File remoting/host/client_session.cc

Line 164, Patchset 4 (Latest): if (desktop_environment_options.enable_security_key()) {

Yuwei Huang . unresolved

By moving `SecurityKeyExtension` creation here, it is added unconditionally (if the host option is enabled), bypassing the `security_key_auth_policy_enabled_` check that used to be in `RemotingMe2MeHost`.

Because `SecurityKeyExtensionSession` no longer has access to policies, it will process gnubby control/data messages even if the enterprise policy disables it, potentially causing a policy bypass.

To fix this in the interim before the data channel migration is complete, read the local policy from `local_session_policies_provider_`. This will ensure you are on par with the old behavior.

File remoting/host/remoting_me2me_host.cc

Line 2053, Patchset 4 (Parent): if (security_key_auth_policy_enabled_ &&

Yuwei Huang . unresolved

Since `SecurityKeyExtension` lifecycle has been moved to `ClientSession`, `security_key_auth_policy_enabled_` is no longer used to gate the extension.

As mentioned in the TODO above `OnGnubbyAuthPolicyUpdate()`, this callback and the associated host restart logic can likely be completely removed now.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages