Increase test coverage in /remoting/signaling - Part 1 [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 6, 2026, 4:44:15 PM (8 days ago) Mar 6
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 6, 2026, 6:02:24 PM (8 days ago) Mar 6
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/signaling/jingle_message_xml_converter_unittest.cc
Line 35, Patchset 3 (Latest):
*error = "<" + exp->Name().Merged() + ">" + " is expected, but " + "<" +Yuwei Huang . unresolved
Would it be more readable if you rewrite it with `base::StringPrintf`?
https://source.chromium.org/chromium/chromium/src/+/main:base/strings/stringprintf.h
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 9, 2026, 12:52:52 PM (5 days ago) Mar 9
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Joe Downing . resolved
Thanks! Can you take a look at the diff please since your +1 was revoked :(
File remoting/signaling/jingle_message_xml_converter_unittest.cc
Line 35, Patchset 3:
*error = "<" + exp->Name().Merged() + ">" + " is expected, but " + "<" +Yuwei Huang . resolved
Would it be more readable if you rewrite it with `base::StringPrintf`?
https://source.chromium.org/chromium/chromium/src/+/main:base/strings/stringprintf.h
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 9, 2026, 4:54:59 PM (5 days ago) Mar 9
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 9, 2026, 4:55:37 PM (5 days ago) Mar 9
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 9, 2026, 5:00:34 PM (5 days ago) Mar 9
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Increase test coverage in /remoting/signaling - Part 1
I'm going to start adding the code to handle structured jingle
messages in the service protos but I wanted to ensure we have solid
test coverage in /signaling before modifying the code. This CL adds
tests for several existing FTL classes and for the XML converter class.
Bug: 359620500
Change-Id: I7d830fca8c9e212117ff52ac787c8e186f6fa8af
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Auto-Submit: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1596590}
Files:
- M remoting/signaling/BUILD.gn
- A remoting/signaling/ftl_device_id_provider_unittest.cc
- M remoting/signaling/ftl_registration_manager_unittest.cc
- A remoting/signaling/ftl_services_context_unittest.cc
- M remoting/signaling/jingle_data_structures_unittest.cc
- M remoting/signaling/jingle_message_xml_converter.cc
- A remoting/signaling/jingle_message_xml_converter_unittest.cc
- M remoting/signaling/signaling_id_util_unittest.cc
Change size: L
Delta: 8 files changed, 625 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages