Update MAGI to handle both true and simulated MAS tools [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
May 20, 2026, 1:39:50 PM (yesterday) May 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I189918bd11ca6d0d3e0a4774bed21677cfcc9839
Gerrit-Change-Number: 7863212
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 17:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
May 20, 2026, 2:31:00 PM (yesterday) May 20
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I189918bd11ca6d0d3e0a4774bed21677cfcc9839
    Gerrit-Change-Number: 7863212
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Joe Downing <joe...@chromium.org>
    Gerrit-Comment-Date: Wed, 20 May 2026 18:30:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Joe Downing (Gerrit)

    unread,
    May 20, 2026, 2:40:36 PM (yesterday) May 20
    to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

    Joe Downing voted and added 1 comment

    Votes added by Joe Downing

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Joe Downing . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I189918bd11ca6d0d3e0a4774bed21677cfcc9839
    Gerrit-Change-Number: 7863212
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Wed, 20 May 2026 18:40:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 20, 2026, 3:28:02 PM (yesterday) May 20
    to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Update MAGI to handle both true and simulated MAS tools

    So...it turns out that some tools are not actually capable of
    running sub-agents concurrently. Instead they 'simulate' the
    agents using the main agent. This means that a multi-agent
    SKILL which is optimized for a "true MAS" tool will not perform
    as well on the "simulated MAS" tool.

    This CL adds a grounding directive for the agents, especially the
    Orchestrator, to indicate whether the protocol should run in a
    centralized fashion for a simulated MAS tool or decentralized
    for a true-MAS tool.
    Change-Id: I189918bd11ca6d0d3e0a4774bed21677cfcc9839
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Reviewed-by: Yuwei Huang <yuw...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1633756}
    Files:
    • M remoting/tools/magi-mode/SKILL.md
    • M remoting/tools/magi-mode/magi_schema.json
    • M remoting/tools/magi-mode/personas/ai/mas.json
    • M remoting/tools/magi-mode/personas/core/scoping.json
    • M remoting/tools/magi-mode/tests/magi_stage_specify_tests.json
    • M remoting/tools/magi-mode/tests/testdata/project.magi.json
    Change size: L
    Delta: 6 files changed, 351 insertions(+), 97 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuwei Huang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I189918bd11ca6d0d3e0a4774bed21677cfcc9839
    Gerrit-Change-Number: 7863212
    Gerrit-PatchSet: 4
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages