Remove XmlElement-based SendIq methods in IqSender [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Feb 20, 2026, 12:01:07 PM (2 days ago) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 20, 2026, 3:58:08 PM (2 days ago) Feb 20
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/protocol/jingle_session.cc
Line 581, Patchset 2 (Latest):
std::string message_id = message->message_id;Yuwei Huang . unresolved
nit: just pass `message->message_id` to `OnIncomingMessage` to avoid unnecessary copy.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 20, 2026, 4:46:21 PM (2 days ago) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/protocol/jingle_session.cc
Line 581, Patchset 2 (Latest):
std::string message_id = message->message_id;Yuwei Huang . resolved
nit: just pass `message->message_id` to `OnIncomingMessage` to avoid unnecessary copy.
Joe Downing
Interestingly I had this problem in a previous CL where I tried both referencing a member and std::moving'ing the instance in the same function invocation. This worked fine on posix (meaning no crash) but the Windows binary crashed when the code was executed. My guess is that it depends on which way the values are pushed on the stack for the fn call.
I would prefer fixing this in a follow-up where OrderedMessageQueue reads message_id from PendingMessage.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 4:49:25 PM (2 days ago) Feb 20
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove XmlElement-based SendIq methods in IqSender
Yet another CL in a long line of refactoring CLs which aim to
remove the XmlElement dependency from the myriad signaling and
protocol classes.
Bug: 359620500
Change-Id: Iadaf54e0f340f9be886b9039f75ef49ca35a0245
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1588078}
Files:
- M remoting/protocol/jingle_session.cc
- M remoting/protocol/jingle_session.h
- M remoting/protocol/jingle_session_manager.cc
- M remoting/signaling/iq_sender.cc
- M remoting/signaling/iq_sender.h
- M remoting/signaling/iq_sender_unittest.cc
- M remoting/signaling/jingle_data_structures_unittest.cc
Change size: M
Delta: 7 files changed, 50 insertions(+), 102 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages