Track password elements using the TrackedElement framework [chromium/src : main]

[Ryan Kalla (Gerrit)]

Attention needed from Khushal Sagar and Nan Lin

Ryan Kalla voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Khushal Sagar
• Nan Lin

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Gerrit-Change-Number: 7837758

Gerrit-PatchSet: 12

Gerrit-Owner: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>

Gerrit-Comment-Date: Mon, 18 May 2026 16:31:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Nan Lin (Gerrit)]

Attention needed from Khushal Sagar

Nan Lin added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Nan Lin . resolved

@khusha...@chromium.org Just friendly ping, could you PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Khushal Sagar

Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>

Gerrit-Comment-Date: Mon, 18 May 2026 16:33:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nan Lin (Gerrit)]

Attention needed from Khushal Sagar

Nan Lin removed vinnypersky+...@google.com from this change

Deleted Reviewers:

• vinnypersky+...@google.com

Open in Gerrit

Related details

Attention is currently required from:

• Khushal Sagar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteReviewer

[Nan Lin (Gerrit)]

Attention needed from Khushal Sagar

Nan Lin removed yuzo+...@chromium.org from this change

Deleted Reviewers:

• yuzo+...@chromium.org

[Nan Lin (Gerrit)]

Attention needed from Khushal Sagar

Nan Lin removed trewin...@google.com from this change

Deleted Reviewers:

• trewin...@google.com

[Khushal Sagar (Gerrit)]

Attention needed from Nan Lin

Khushal Sagar added 2 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Khushal Sagar . resolved

Sorry for the delay, just one minor comment.

File third_party/blink/renderer/core/dom/element.h

Line 2077, Patchset 12 (Latest): // Returns true if this element is a native password field or has been
// identified as a custom password field via CSS or JS heuristics.
virtual bool IsNativeOrHeuristicPassword() const;

Khushal Sagar . unresolved

Can we avoid adding this virtual API here? This is being used to detect if this is a native password from ShouldTrackPassword which is already virtual. So we can fold it into ShouldTrackPassword() itself?

Open in Gerrit

Related details

Attention is currently required from:

• Nan Lin

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Gerrit-Change-Number: 7837758

Gerrit-PatchSet: 12

Gerrit-Owner: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Comment-Date: Mon, 18 May 2026 20:46:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nan Lin (Gerrit)]

Attention needed from Khushal Sagar

Nan Lin added 1 comment

File third_party/blink/renderer/core/dom/element.h

Line 2077, Patchset 12 (Latest): // Returns true if this element is a native password field or has been
// identified as a custom password field via CSS or JS heuristics.
virtual bool IsNativeOrHeuristicPassword() const;

Khushal Sagar . unresolved

Can we avoid adding this virtual API here? This is being used to detect if this is a native password from ShouldTrackPassword which is already virtual. So we can fold it into ShouldTrackPassword() itself?

Nan Lin

I added this function so that it's clear to answer 1. if this is a password (IsNativeOrHeuristicPassword) 2. should we track this element if it's a password (ShouldTrackPassword). We can definitely fold it into ShouldTrackPassword(), but that would complicate ShouldTrackPassword() and duplicate some logic (e.g. HtmlInputElement would need to check if the value is empty or not, which is currently handled by TextControlElement). I don't feel strongly, but please let me know if you prefer to have one fewer virtual function. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

• Khushal Sagar

Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>

Gerrit-Comment-Date: Mon, 18 May 2026 21:09:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Khushal Sagar <khusha...@chromium.org>

[Khushal Sagar (Gerrit)]

Attention needed from Nan Lin

Khushal Sagar voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Nan Lin

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Gerrit-Change-Number: 7837758

Gerrit-PatchSet: 12

Gerrit-Owner: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Comment-Date: Wed, 20 May 2026 22:06:18 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Khushal Sagar (Gerrit)]

Attention needed from Nan Lin

Khushal Sagar added 1 comment

File third_party/blink/renderer/core/dom/element.h

Line 2077, Patchset 12 (Latest): // Returns true if this element is a native password field or has been
// identified as a custom password field via CSS or JS heuristics.
virtual bool IsNativeOrHeuristicPassword() const;

Khushal Sagar . resolved

Can we avoid adding this virtual API here? This is being used to detect if this is a native password from ShouldTrackPassword which is already virtual. So we can fold it into ShouldTrackPassword() itself?

Nan Lin

I added this function so that it's clear to answer 1. if this is a password (IsNativeOrHeuristicPassword) 2. should we track this element if it's a password (ShouldTrackPassword). We can definitely fold it into ShouldTrackPassword(), but that would complicate ShouldTrackPassword() and duplicate some logic (e.g. HtmlInputElement would need to check if the value is empty or not, which is currently handled by TextControlElement). I don't feel strongly, but please let me know if you prefer to have one fewer virtual function. Thanks.

Khushal Sagar

Ack. Keeping them separate also seems good.

Gerrit-Comment-Date: Wed, 20 May 2026 22:07:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nan Lin <lin...@chromium.org>

Comment-In-Reply-To: Khushal Sagar <khusha...@chromium.org>

[Nan Lin (Gerrit)]

Nan Lin added 2 comments

Patchset-level comments

File-level comment, Patchset 5:

Khushal Sagar . resolved

One high level question for this CL, and something I missed for the iframe case,
sorry i thought i sent it yesterday. :)

why do we dynamically add/remove element tracking when an element is inserted or detached from the DOM?

It seems we have state changes which initiate tracking (if it's an iframe element, if it's an input element with type=password, if it's an input element which has CSS applied that heuristically makes it a password). And once that's initiated, the element continues to be tracked. If the element has been detached, it will no longer be in the layout or paint tree so it won't show up in the data provided by the compositor. But there's no reason to remove the tracking, it seems like we're creating unnecessary complexity.

So how about we create one helper to add the element to the tracking list. And any place where the state that initiates tracking changes, calls that helper.

Nan Lin

Thanks Khushal, that makes a lot of sense. I agreed that although detached elements don't need to be tracked, it adds more complexity. I'll simplify the implementation by removing the dynamic add/remove logic from `InsertedInto` and `RemovedFrom`. Since the compositor ignores elements without a layout object, we only need to ensure the tracking state is correctly set based on whether the element is a password field (via type or heuristics).

Element::UpdatePasswordTracking() is the helper function that is called when the state changes for password. I'll remove the `isConnected()` check there as well.

Nan Lin

Done

File-level comment, Patchset 12 (Latest):

Nan Lin . resolved

Thank you!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Gerrit-Comment-Date: Thu, 21 May 2026 00:01:14 +0000

[Nan Lin (Gerrit)]

Nan Lin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Gerrit-Change-Number: 7837758

Gerrit-PatchSet: 13

Gerrit-Owner: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Comment-Date: Thu, 21 May 2026 04:28:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Unreviewed changes

12 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Track password elements using the TrackedElement framework

This CL leverages the existing TrackedElement infrastructure to track
the coordinates of password elements. This is a prerequisite for
screenshot redaction via compositor, ensuring that sensitive fields can
be accurately masked in sync with the captured viewport bitmap.

Bug: 439921639

Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7837758

Reviewed-by: Ryan Kalla <ryan...@google.com>

Commit-Queue: Nan Lin <lin...@chromium.org>

Reviewed-by: Khushal Sagar <khusha...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1634047}

Files:

• M components/viz/common/surfaces/tracked_element_rects.h
• M third_party/blink/renderer/core/dom/element.cc
• M third_party/blink/renderer/core/dom/element.h
• M third_party/blink/renderer/core/dom/element_test.cc
• M third_party/blink/renderer/core/html/forms/html_input_element.cc
• M third_party/blink/renderer/core/html/forms/html_input_element.h
• M third_party/blink/renderer/core/html/forms/html_input_element_test.cc
• M third_party/blink/renderer/core/html/forms/text_control_element.cc
• M third_party/blink/renderer/core/html/forms/text_control_element.h
• M third_party/blink/renderer/core/html/forms/text_control_element_test.cc
• M third_party/blink/renderer/platform/runtime_enabled_features.json5

Change size: M

Delta: 11 files changed, 203 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Khushal Sagar, +1 by Ryan Kalla

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Gerrit-Change-Number: 7837758

Gerrit-PatchSet: 14

Gerrit-Owner: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

[Pathum Lakmal (Gerrit)]

Pathum Lakmal added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Pathum Lakmal . resolved

Pathu...@gmail.com

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Gerrit-Change-Number: 7837758

Gerrit-PatchSet: 14

Gerrit-Owner: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Pathum Lakmal <pathu...@gmail.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Comment-Date: Thu, 21 May 2026 05:08:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No