remoting: PC Process Child Implementation [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Jun 10, 2026, 9:06:12 PMJun 10
to chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang added 1 comment![]( "Open in Gerrit")
File remoting/host/peer_connection_process.cc
Line 25, Patchset 4 (Latest):
DCHECK(caller_task_runner_->BelongsToCurrentThread());Yuwei Huang . unresolved
BUG: `caller_task_runner_` is set to `nullptr` in `OnChannelError()` during shutdown. When the `PeerConnectionProcess` is subsequently destroyed, this `DCHECK` will dereference a null pointer and crash the process during exit.
Consider adding a null check:
```cpp
if (caller_task_runner_) {
DCHECK(caller_task_runner_->BelongsToCurrentThread());
}
```
Or simply remove the `DCHECK`.
---
Human comment: TBH you should just use `SEQUENCE_CHECKER` then you don't need to worry about it.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 10, 2026, 9:39:13 PMJun 10
to chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang added 1 comment![]( "Open in Gerrit")
File remoting/host/peer_connection_process.cc
BUG: `caller_task_runner_` is set to `nullptr` in `OnChannelError()` during shutdown. When the `PeerConnectionProcess` is subsequently destroyed, this `DCHECK` will dereference a null pointer and crash the process during exit.
Consider adding a null check:
```cpp
if (caller_task_runner_) {
DCHECK(caller_task_runner_->BelongsToCurrentThread());
}
```
Or simply remove the `DCHECK`.---
Human comment: TBH you should just use `SEQUENCE_CHECKER` then you don't need to worry about it.
Yuwei Huang
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 10, 2026, 9:47:01 PMJun 10
to chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang added 1 comment![]( "Open in Gerrit")
File remoting/host/peer_connection_process_main.cc
Line 37, Patchset 5 (Latest):
scoped_refptr<AutoThreadTaskRunner> ui_task_runner = new AutoThreadTaskRunner(Yuwei Huang . unresolved
NIT: Prefer using `base::MakeRefCounted<AutoThreadTaskRunner>(...)` over `new` here, as is standard in Chromium.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 10, 2026, 9:55:01 PMJun 10
to chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang added 1 comment![]( "Open in Gerrit")
File remoting/host/peer_connection_process_main.cc
Line 37, Patchset 5:
scoped_refptr<AutoThreadTaskRunner> ui_task_runner = new AutoThreadTaskRunner(Yuwei Huang . resolved
NIT: Prefer using `base::MakeRefCounted<AutoThreadTaskRunner>(...)` over `new` here, as is standard in Chromium.
Yuwei Huang
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 10, 2026, 9:55:28 PMJun 10
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Jun 11, 2026, 3:27:34 PMJun 11
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 18, 2026, 5:44:39 PM (10 days ago) Jun 18
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 6:22:30 PM (10 days ago) Jun 18
to Yuwei Huang, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/host/peer_connection_process.cc
Insertions: 0, Deletions: 8.
The diff is too large to show. Please review the diff.
```
```
The name of the file: remoting/host/peer_connection_process.h
Insertions: 0, Deletions: 4.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
remoting: PC Process Child Implementation
Implement the child process side for the dedicated Peer Connection (PC)
process. This includes:
- PeerConnectionProcess class which implements the
mojom::PeerConnectionProcessControl interface and handles Mojo
bootstrap.
- PeerConnectionProcessMain entry point.
- Registering the entry point in host_main.cc under the
"peer_connection" process type.
TAG=agy
CONV=bf005916-ada6-4139-af52-be0884b5cbf0
Bug: 502281489
Change-Id: I4e4ba2a81ec586dc4200416914bd984a247114b5
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649347}
Files:
- M remoting/host/BUILD.gn
- M remoting/host/host_main.cc
- A remoting/host/peer_connection_process.cc
- A remoting/host/peer_connection_process.h
- A remoting/host/peer_connection_process_main.cc
Change size: L
Delta: 5 files changed, 250 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages