Use span-based file API in audio_pipe_reader.cc [chromium/src : main]
0 views
Skip to first unread message
Jan Keitel (Gerrit)
Jan 9, 2026, 5:48:22 AM (12 days ago) Jan 9
to Yuwei Huang, Chromium LUCI CQ, AyeAye, chromotin...@chromium.org
Attention needed from Yuwei Huang
Jan Keitel voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jan 12, 2026, 7:44:54 PM (8 days ago) Jan 12
to Jan Keitel, Chromium LUCI CQ, AyeAye, chromotin...@chromium.org
Attention needed from Jan Keitel
Yuwei Huang added 1 comment![]( "Open in Gerrit")
File remoting/host/linux/audio_pipe_reader.cc
Line 164, Patchset 2 (Latest):
if (read_bytes > 0) {Yuwei Huang . unresolved
`read_bytes.value_or(0)`. `std::optional` does seem to have an [`operator>()`](https://en.cppreference.com/w/cpp/utility/optional.html), but it is cryptic, and I suspect it is not doing what you are expecting.
```suggestion
if (read_bytes.value_or(0) > 0) {
```
Related details
Attention is currently required from:
- Jan Keitel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jan Keitel (Gerrit)
Jan 13, 2026, 2:05:11 AM (8 days ago) Jan 13
to Yuwei Huang, Chromium LUCI CQ, AyeAye, chromotin...@chromium.org
Attention needed from Yuwei Huang
Jan Keitel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jan Keitel
| Auto-Submit | +1 |
1 comment
File remoting/host/linux/audio_pipe_reader.cc
`read_bytes.value_or(0)`. `std::optional` does seem to have an [`operator>()`](https://en.cppreference.com/w/cpp/utility/optional.html), but it is cryptic, and I suspect it is not doing what you are expecting.
```suggestion
if (read_bytes.value_or(0) > 0) {
```
Jan Keitel
The previous code was intentional and did the right thing - `std::nullopt` always compares smaller than what can be contained. I've added the `value_or` part for explicitness, though.
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jan 14, 2026, 4:08:53 PM (6 days ago) Jan 14
to Jan Keitel, Chromium LUCI CQ, AyeAye, chromotin...@chromium.org
Attention needed from Jan Keitel
Yuwei Huang voted![]( "Open in Gerrit")
Attention is currently required from:
- Jan Keitel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 14, 2026, 5:00:13 PM (6 days ago) Jan 14
to Jan Keitel, Yuwei Huang, AyeAye, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use span-based file API in audio_pipe_reader.cc
No functionality changes.
Bug: 435317390
Change-Id: I1729063df3fb86b0178d749b5aace04d16d2a8b1
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Auto-Submit: Jan Keitel <jke...@google.com>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569317}
Files:
- M remoting/host/linux/audio_pipe_reader.cc
Change size: S
Delta: 1 file changed, 7 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages