Add a JSON checker and formatter for MAGI [chromium/src : main]
Joe Downing (Gerrit)
Joe Downing added 2 comments![]( "Open in Gerrit")
import importlib.utilCan you move this import to the top of the file?
check_json_format = importlib.util.module_from_spec(spec)If `exec_module` raises a `FileNotFoundError` (or any other exception), `check_json_format` will still refer to the unexecuted module object. Because it is not `None`, the script will later attempt to call `check_json_format.CheckFormatting(...)` which will crash with an `AttributeError`.\n\nConsider using a temporary variable and only assigning `check_json_format` upon success:\n```python\n if spec:\n mod = importlib.util.module_from_spec(spec)\n spec.loader.exec_module(mod)\n check_json_format = mod\n```
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing added 2 comments![]( "Open in Gerrit")
Can you move this import to the top of the file?
Done
check_json_format = importlib.util.module_from_spec(spec)If `exec_module` raises a `FileNotFoundError` (or any other exception), `check_json_format` will still refer to the unexecuted module object. Because it is not `None`, the script will later attempt to call `check_json_format.CheckFormatting(...)` which will crash with an `AttributeError`.\n\nConsider using a temporary variable and only assigning `check_json_format` upon success:\n```python\n if spec:\n mod = importlib.util.module_from_spec(spec)\n spec.loader.exec_module(mod)\n check_json_format = mod\n```
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
Related details
- Yuwei Huang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
- Joe Downing
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Thanks!
Related details
- Joe Downing
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Add a JSON checker and formatter for MAGI
AFAICT the normal Chromium linter and formatters do not handle
JSON so I added a script to handle this and ensure all of the
MAGI JSON files are formatted consistently.
- M remoting/tools/magi-mode/PRESUBMIT.py
- M remoting/tools/magi-mode/PRESUBMIT_test.py
- A remoting/tools/magi-mode/check_json_format.py
- M remoting/tools/magi-mode/magi_schema.json
- M remoting/tools/magi-mode/personas/ai/mas.json
- M remoting/tools/magi-mode/personas/core/scoping.json
- M remoting/tools/magi-mode/personas/infra/chromium_build.json
- M remoting/tools/magi-mode/tests/magi_stage_specify_tests.json
- M remoting/tools/magi-mode/tests/magi_test_schemas.json
- M remoting/tools/magi-mode/tests/testdata/project.magi.json
- M remoting/tools/magi-mode/tests/testdata/state_block.magi.json
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |