[remoting] More refactoring for SecurityKeyAuthHandler [chromium/src : main]
Yuwei Huang (Gerrit)
Yuwei Huang added 5 comments![]( "Open in Gerrit")
remoting::SecurityKeyAuthHandler::Init(std::move(options));Yuwei HuangWhy do you only call `Init` for POSIX? It is possible that we later add init options specifically for Windows.
Done
io_task_runner_, SecurityKeyAuthHandler::GetSocketName());Yuwei HuangWhy do you need to pass this? Is this for testing? If so, can you make this optional and defaulted to `GetSocketName()`?
Done
security_key_extension_supported_ = false;Yuwei HuangIs the `security_key_extension_supported_` variable still needed, or can it be removed?
Done
// Initializes the global configuration. Should be called at host startup.Yuwei Huang"Must be called before `Create` is called."
Done
session_policies.allow_gnubby_forwarding =Yuwei HuangPlease also add this to remoting/proto/google/internal/remoting/cloud/v1alpha/session_policies.proto and add the conversion logic.
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang added 3 comments![]( "Open in Gerrit")
hook and a platform-specific ResetTaskRunnerForTesting() hook.Where is this hook?
if (security_key_auth_policy_enabled_ &&This should be replaced with a check to `allow_gnubby_forwarding`.
SecurityKeyAuthHandlerPosix();The docstring here describes `socket_name` and `file_task_runner` parameters, but this is the default constructor with no parameters. The docstring probably belongs to the private constructor below.
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang added 4 comments![]( "Open in Gerrit")
hook and a platform-specific ResetTaskRunnerForTesting() hook.Yuwei HuangWhere is this hook?
Done
#include "remoting/host/security_key/security_key_auth_handler.h"This include needs to be moved outside of the `#if BUILDFLAG(IS_POSIX)` block. `remoting::SecurityKeyAuthHandler::Init()` is now called unconditionally below, so if `IS_POSIX` is false (e.g., on Windows), the build will fail because `SecurityKeyAuthHandler` is not declared.
This should be replaced with a check to `allow_gnubby_forwarding`.
Done
The docstring here describes `socket_name` and `file_task_runner` parameters, but this is the default constructor with no parameters. The docstring probably belongs to the private constructor below.
Done
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang added 1 comment![]( "Open in Gerrit")
#include "remoting/host/security_key/security_key_auth_handler.h"This include needs to be moved outside of the `#if BUILDFLAG(IS_POSIX)` block. `remoting::SecurityKeyAuthHandler::Init()` is now called unconditionally below, so if `IS_POSIX` is false (e.g., on Windows), the build will fail because `SecurityKeyAuthHandler` is not declared.
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Related details
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |