[crd host][linux] Implement remote_session_info binary [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Mar 10, 2026, 7:10:24 PM (4 days ago) Mar 10
to Lambros Lambrou, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Lambros Lambrou
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Lambros Lambrou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Mar 10, 2026, 7:52:24 PM (4 days ago) Mar 10
to Yuwei Huang, Chromium LUCI CQ, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang
Lambros Lambrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lambros Lambrou
| Code-Review | +1 |
1 comment
File remoting/host/linux/login_session_server.cc
Line 60, Patchset 5 (Latest):
int ret = sd_pid_get_session(pid, &session_id);Lambros Lambrou . unresolved
Please could you add comments to explain this logic? It looks like you try `sd_pid_get_session()`, then if it fails, you test if the pid is in a graphical session. If it is, then you use `sd_uid_get_display()` and `sd_pid_get_owner_uid()`. Please could you explain why this fallback is needed?
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 10, 2026, 8:20:22 PM (4 days ago) Mar 10
to Chromium IPC Reviews, Lambros Lambrou, Chromium LUCI CQ, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Chromium IPC Reviews
Yuwei Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File remoting/host/linux/login_session_server.cc
Please could you add comments to explain this logic? It looks like you try `sd_pid_get_session()`, then if it fails, you test if the pid is in a graphical session. If it is, then you use `sd_uid_get_display()` and `sd_pid_get_owner_uid()`. Please could you explain why this fallback is needed?
Yuwei Huang
Apparently gemini copied these from `login_session_reporter_main.cc` and decided not to copied the comments over 😅 Added them back.
Related details
Attention is currently required from:
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Mar 10, 2026, 8:23:38 PM (4 days ago) Mar 10
to Yuwei Huang, Chromium IPC Reviews, Mustafa Emre Acer, Lambros Lambrou, Chromium LUCI CQ, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Mustafa Emre Acer
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mea...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mea...@chromium.org
Reviewer source(s):
mea...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mustafa Emre Acer (Gerrit)
Mar 11, 2026, 2:19:37 PM (4 days ago) Mar 11
to Yuwei Huang, Chromium IPC Reviews, Lambros Lambrou, Chromium LUCI CQ, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang
Mustafa Emre Acer voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mustafa Emre Acer
| Code-Review | +1 |
2 comments
Patchset-level comments
Mustafa Emre Acer . resolved
LGTM
File remoting/host/ipc_constants.h
Line 53, Patchset 6 (Latest):
// Returns the server name for LonginSessionServer.Mustafa Emre Acer . unresolved
nit: typo in LonginSessionServer
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 11, 2026, 2:48:38 PM (3 days ago) Mar 11
to Mustafa Emre Acer, Chromium IPC Reviews, Lambros Lambrou, Chromium LUCI CQ, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Yuwei Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/host/ipc_constants.h
Line 53, Patchset 6:
// Returns the server name for LonginSessionServer.Mustafa Emre Acer . resolved
Yuwei Huangnit: typo in LonginSessionServer
Oops.. Done!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 11, 2026, 3:01:48 PM (3 days ago) Mar 11
to Mustafa Emre Acer, Chromium IPC Reviews, Lambros Lambrou, Chromium LUCI CQ, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Yuwei Huang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Mar 11, 2026, 5:16:18 PM (3 days ago) Mar 11
to Yuwei Huang, Mustafa Emre Acer, Chromium IPC Reviews, Lambros Lambrou, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/host/ipc_constants.h
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[crd host][linux] Implement remote_session_info binary
This is to replace the CHROME_REMOTE_DESKTOP_SESSION env var, which we
can't reliably set for GDM-managed sessions. It makes an IPC to the
daemon process, and the daemon process will iterate through all its
display sessions and check if the calling process (remote_session_info)
is run on any of the session it manages.
The existing is-remoting-session script will be updated to point to this
binary, i.e. `remote-session-info --is-crd-session`.
Bug: 475611769,b/478991859
Change-Id: Ib35be11c4d56c80583212926cbccfda978d99202
Reviewed-by: Mustafa Emre Acer <mea...@chromium.org>
Auto-Submit: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597987}
Files:
- M remoting/host/BUILD.gn
- M remoting/host/ipc_constants.cc
- M remoting/host/ipc_constants.h
- M remoting/host/linux/BUILD.gn
- A remoting/host/linux/login_session_server.cc
- A remoting/host/linux/login_session_server.h
- M remoting/host/linux/remote_display_session_manager.cc
- M remoting/host/linux/remote_display_session_manager.h
- A remoting/host/linux/remote_session_info_entry_point.cc
- A remoting/host/linux/remote_session_info_main.cc
- A remoting/host/linux/remote_session_info_main.h
- M remoting/host/mojo_caller_security_checker.cc
- M remoting/host/mojom/login_session.mojom
Change size: L
Delta: 13 files changed, 400 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mustafa Emre Acer, +1 by Lambros Lambrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages