Add a SendIq override in IqSender which takes a JingleMessage [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Feb 20, 2026, 11:02:46 AM (2 days ago) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 20, 2026, 3:56:06 PM (2 days ago) Feb 20
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 4:49:11 PM (2 days ago) Feb 20
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add a SendIq override in IqSender which takes a JingleMessage
Yet another CL in a long line of refactoring CLs which aim to
remove the XmlElement dependency from the myriad signaling and
protocol classes.
I'll follow up with a CL which convert more call sites to use
the new SendIq override.
Bug: 359620500
Change-Id: I85738a8f22c2220d69483aa170c35c0f121d191e
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1588077}
Files:
- M remoting/protocol/jingle_session.cc
- M remoting/signaling/iq_sender.cc
- M remoting/signaling/iq_sender.h
- M remoting/signaling/iq_sender_unittest.cc
- M remoting/signaling/jingle_data_structures.h
- M remoting/signaling/jingle_message_xml_converter.cc
Change size: M
Delta: 6 files changed, 55 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages