Add a SendIq override in IqSender which takes a JingleMessage [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
Feb 20, 2026, 11:02:46 AM (2 days ago) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I85738a8f22c2220d69483aa170c35c0f121d191e
Gerrit-Change-Number: 7595941
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 16:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
Feb 20, 2026, 3:56:06 PM (2 days ago) Feb 20
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I85738a8f22c2220d69483aa170c35c0f121d191e
    Gerrit-Change-Number: 7595941
    Gerrit-PatchSet: 4
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Joe Downing <joe...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 20:55:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 20, 2026, 4:49:11 PM (2 days ago) Feb 20
    to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add a SendIq override in IqSender which takes a JingleMessage

    Yet another CL in a long line of refactoring CLs which aim to
    remove the XmlElement dependency from the myriad signaling and
    protocol classes.

    I'll follow up with a CL which convert more call sites to use
    the new SendIq override.
    Bug: 359620500
    Change-Id: I85738a8f22c2220d69483aa170c35c0f121d191e
    Reviewed-by: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1588077}
    Files:
    • M remoting/protocol/jingle_session.cc
    • M remoting/signaling/iq_sender.cc
    • M remoting/signaling/iq_sender.h
    • M remoting/signaling/iq_sender_unittest.cc
    • M remoting/signaling/jingle_data_structures.h
    • M remoting/signaling/jingle_message_xml_converter.cc
    Change size: M
    Delta: 6 files changed, 55 insertions(+), 16 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuwei Huang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I85738a8f22c2220d69483aa170c35c0f121d191e
    Gerrit-Change-Number: 7595941
    Gerrit-PatchSet: 5
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages