Tom Sepez (Gerrit)

unread,

Mar 21, 2025, 1:54:29 PM3/21/25

to Alex Gough, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, ningxin hu, Peter Beverloo, Jiewei Qian, Rijubrata Bhaumik, Wanming Lin, sky+...@chromium.org, abigailbk...@google.com, chfreme...@chromium.org, chromeos-gfx-...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, grt+...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rlp+...@chromium.org, roblia...@chromium.org, rousla...@chromium.org, scheduler...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from Alex Gough

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Alex Gough

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Gough (Gerrit)

unread,

Mar 21, 2025, 4:04:00 PM3/21/25

to Tom Sepez, Alex Gough, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, ningxin hu, Peter Beverloo, Jiewei Qian, Rijubrata Bhaumik, Wanming Lin, sky+...@chromium.org, abigailbk...@google.com, chfreme...@chromium.org, chromeos-gfx-...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, grt+...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rlp+...@chromium.org, roblia...@chromium.org, rousla...@chromium.org, scheduler...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from Tom Sepez

Alex Gough voted and added 1 comment

Votes added by Alex Gough

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Alex Gough . resolved

lgtm w/OO+1

Open in Gerrit

Related details

Attention is currently required from:

Tom Sepez

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Mar 24, 2025, 12:15:42 PM3/24/25

to Alex Gough, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, ningxin hu, Peter Beverloo, Jiewei Qian, Rijubrata Bhaumik, Wanming Lin, sky+...@chromium.org, abigailbk...@google.com, chfreme...@chromium.org, chromeos-gfx-...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, grt+...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rlp+...@chromium.org, roblia...@chromium.org, rousla...@chromium.org, scheduler...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Tom Sepez voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 24, 2025, 2:00:54 PM3/24/25

to Tom Sepez, Alex Gough, AyeAye, Akihiro Ota, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, ningxin hu, Peter Beverloo, Jiewei Qian, Rijubrata Bhaumik, Wanming Lin, sky+...@chromium.org, abigailbk...@google.com, chfreme...@chromium.org, chromeos-gfx-...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, grt+...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rlp+...@chromium.org, roblia...@chromium.org, rousla...@chromium.org, scheduler...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Suppress still even more unsafe libc calls

Another batch of mainly win files.

Change-Id: Idceca6376cf389c9acdfc39d0723631c4b8cd249

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378183

Reviewed-by: Alex Gough <aj...@chromium.org>

Owners-Override: Alex Gough <aj...@chromium.org>

Commit-Queue: Tom Sepez <tse...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1436967}

Files:

M base/task/single_thread_task_executor_unittest.cc
M base/win/event_trace_consumer_unittest.cc
M base/win/i18n_unittest.cc
M base/win/winrt_storage_util_unittest.cc
M chrome/browser/browser_switcher/alternative_browser_driver_win.cc
M chrome/browser/chrome_process_singleton.cc
M chrome/browser/printing/pdf_to_emf_converter.cc
M chrome/browser/ui/views/device_id/pen_id_browsertest_win.cc
M chrome/browser/ui/views/status_icons/status_icon_win.cc
M chrome/common/win/delay_load_notify_hook_unittest.cc
M chrome/credential_provider/gaiacp/gaia_credential_base.cc
M chrome/credential_provider/gaiacp/gaia_credential_base_unittests.cc
M chrome/credential_provider/gaiacp/os_process_manager.cc
M chrome/credential_provider/gaiacp/scoped_user_profile.cc
M chrome/credential_provider/test/com_fakes.cc
M chrome/test/delayload/delayload_hook_browsertest.cc
M chrome/updater/app/server/win/com_classes_util.cc
M chrome/updater/win/setup/setup_util.cc
M chrome/utility/importer/edge_database_reader_unittest_win.cc
M chrome/utility/importer/edge_database_reader_win.cc
M chrome/utility/importer/edge_importer_win.cc
M chrome/utility/importer/ie_importer_win.cc
M components/spellcheck/browser/windows_spell_checker.cc
M components/storage_monitor/storage_monitor_win_unittest.cc
M components/storage_monitor/volume_mount_watcher_win.cc
M content/child/font_warmup_win_unittest.cc
M content/shell/browser/shell_download_manager_delegate.cc
M device/bluetooth/bluetooth_classic_win_fake.cc
M device/fido/win/webauthn_api.cc
M device/vr/openxr/openxr_controller.cc
M device/vr/openxr/openxr_hand_tracker.cc
M device/vr/openxr/openxr_platform_helper.cc
M gpu/config/gpu_info_collector_win.cc
M media/audio/win/audio_low_latency_input_win_unittest.cc
M media/audio/win/core_audio_util_win.cc
M media/capture/video/win/sink_input_pin_win.cc
M media/cdm/win/test/media_foundation_clear_key_cdm_factory.h
M media/gpu/windows/supported_profile_helpers_unittest.cc
M media/gpu/windows/video_rate_control_wrapper.cc
M media/renderers/win/media_foundation_texture_pool_unittest.cc
M net/cert/internal/path_builder_trust_store_win_unittest.cc
M net/cert/internal/trust_store_win_unittest.cc
M net/http/http_auth_handler_negotiate_unittest.cc
M net/http/http_auth_sspi_win_unittest.cc
M net/http/mock_sspi_library_win.cc
M pdf/pdfium/pdfium_api_wrappers.cc
M printing/backend/win_helper.cc
M printing/emf_win.cc
M printing/print_settings_initializer_win.cc
M printing/printing_context_system_dialog_win.cc
M printing/printing_context_win.cc
M printing/printing_context_win_unittest.cc
M remoting/host/desktop_resizer_win.cc
M remoting/host/win/host_service.cc
M remoting/host/win/launch_native_messaging_host_process.cc
M remoting/host/win/wts_session_process_delegate.cc
M remoting/tools/breakpad_tester_win.cc
M services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
M services/device/hid/hid_connection_win.cc
M services/network/brokered_tcp_client_socket_unittest.cc
M services/webnn/dml/command_recorder_test.cc
M ui/accessibility/platform/ax_platform_node_textchildprovider_win_unittest.cc
M ui/accessibility/platform/ax_platform_node_textprovider_win_unittest.cc
M ui/base/dragdrop/os_exchange_data_win_unittest.cc
M ui/gl/dcomp_presenter_unittest.cc
M ui/gl/test/gl_test_helper.cc
M ui/views/win/hwnd_message_handler.cc
M ui/views/win/pen_event_processor_unittest.cc

Change size: L

Delta: 68 files changed, 252 insertions(+), 148 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Gough

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

นาแสง ทองพัน (Bay G3LA) (Gerrit)

unread,

Feb 21, 2026, 4:55:48 PM (7 hours ago) Feb 21

to Tom Sepez, Chromium LUCI CQ, Alex Gough, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Hu, Ningxin, Peter Beverloo, Jiewei Qian, Rijubrata Bhaumik, Lin, Wanming, sky+...@chromium.org, abigailbk...@google.com, chfreme...@chromium.org, chromeos-gfx-...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, grt+...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rlp+...@chromium.org, roblia...@chromium.org, rousla...@chromium.org, scheduler...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

นาแสง ทองพัน (Bay_G3LA) added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

นาแสง ทองพัน (Bay_G3LA) . resolved

🚁

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Suppress still even more unsafe libc calls [chromium/src : main]

Tom Sepez (Gerrit)

New activity on the change

Related details

Alex Gough (Gerrit)

Alex Gough voted and added 1 comment

Votes added by Alex Gough

1 comment

Related details

Tom Sepez (Gerrit)

Tom Sepez voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

นาแสง ทองพัน (Bay G3LA) (Gerrit)

นาแสง ทองพัน (Bay_G3LA) added 1 comment

Related details