[remoting] Enforce use of .temp/ directory in MAGI tests and protocol [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
May 12, 2026, 4:41:21 PM (9 days ago) May 12
to Yuwei Huang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I006f97b1ebea39ade798b3baff645ba67c0836f5
Gerrit-Change-Number: 7842654
Gerrit-PatchSet: 5
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 20:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
May 12, 2026, 4:52:13 PM (9 days ago) May 12
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Joe Downing abandoned this change.

View Change

Abandoned

Joe Downing abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28ff12e40dc75e5d006e0d51401a9dce4a5b4367
Gerrit-Change-Number: 7841510
Gerrit-PatchSet: 1
Gerrit-Owner: Joe Downing <joe...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
May 12, 2026, 5:58:42 PM (9 days ago) May 12
to Joe Downing, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I006f97b1ebea39ade798b3baff645ba67c0836f5
Gerrit-Change-Number: 7842654
Gerrit-PatchSet: 5
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 21:58:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
May 12, 2026, 6:41:51 PM (9 days ago) May 12
to Yuwei Huang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Commit-Queue+2

1 comment

Patchset-level comments
Joe Downing . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I006f97b1ebea39ade798b3baff645ba67c0836f5
Gerrit-Change-Number: 7842654
Gerrit-PatchSet: 5
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 22:41:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 12, 2026, 6:54:19 PM (9 days ago) May 12
to Joe Downing, Yuwei Huang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[remoting] Enforce use of .temp/ directory in MAGI tests and protocol

Update run_magi_tests.py to use `remoting/tools/magi-mode/.temp/` for
isolated test directories and add file leak detection to ensure agents
don't write outside of it.

Update SKILL.md to strengthen the mandate for agents to use the `.temp/`
directory for all interim files.

TAG=agy
CONV=f8b5b5a4-cedd-4899-b83d-a3eff5d6de55
Change-Id: I006f97b1ebea39ade798b3baff645ba67c0836f5
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1629604}
Files:
  • M remoting/tools/magi-mode/SKILL.md
  • M remoting/tools/magi-mode/run_magi_tests.py
Change size: S
Delta: 2 files changed, 33 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Yuwei Huang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I006f97b1ebea39ade798b3baff645ba67c0836f5
Gerrit-Change-Number: 7842654
Gerrit-PatchSet: 6
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
open
diffy
satisfied_requirement

Joe Downing (Gerrit)

unread,
May 19, 2026, 2:18:12 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Joe Downing abandoned this change.

View Change

Abandoned

Joe Downing abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a6aab9691e71e6e71131c573b9c74da4070a919
Gerrit-Change-Number: 7841431
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages