[crd host] Fix IpcVideoFrameCapturer [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Feb 20, 2026, 6:11:40 AM (yesterday) Feb 20
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 20, 2026, 10:25:55 AM (yesterday) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 20, 2026, 2:48:40 PM (yesterday) Feb 20
to Chromium IPC Reviews, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Chromium IPC Reviews
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Feb 20, 2026, 2:54:37 PM (yesterday) Feb 20
to Yuwei Huang, Chromium IPC Reviews, Matthew Denton, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Matthew Denton
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mpde...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mpde...@chromium.org
Reviewer source(s):
mpde...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Matthew Denton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Denton (Gerrit)
Feb 20, 2026, 5:05:59 PM (yesterday) Feb 20
to Yuwei Huang, Chromium IPC Reviews, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang
Matthew Denton voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 20, 2026, 5:08:53 PM (yesterday) Feb 20
to Matthew Denton, Chromium IPC Reviews, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Yuwei Huang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 5:12:47 PM (yesterday) Feb 20
to Yuwei Huang, Matthew Denton, Chromium IPC Reviews, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[crd host] Fix IpcVideoFrameCapturer
Capture scheduling is now moved into the desktop process, so this CL
fixes IpcVideoFrameCapturer to make it work. More specifically,
CaptureFrame() is removed from the mojo interface while a few new
methods are added to the interface.
DesktopSessionProxy will now wrap IpcVideoFrameCapturer into a
DesktopCapturerProxy, because WebrtcVideoStream will access it on a
dedicated thread.
Bug: 475611769
Change-Id: I3bb089d06d10248448e57b33386b10503f082d82
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Matthew Denton <mpde...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1588098}
Files:
- M remoting/host/desktop_session_proxy.cc
- M remoting/host/ipc_desktop_environment_unittest.cc
- M remoting/host/ipc_video_frame_capturer.cc
- M remoting/host/ipc_video_frame_capturer.h
- M remoting/host/mojo_video_capturer.cc
- M remoting/host/mojo_video_capturer.h
- M remoting/host/mojo_video_capturer_list.cc
- M remoting/host/mojo_video_capturer_list_unittest.cc
- M remoting/host/mojom/desktop_session.mojom
- M remoting/protocol/fake_desktop_capturer.cc
- M remoting/protocol/fake_desktop_capturer.h
- M remoting/protocol/webrtc_video_stream.cc
Change size: M
Delta: 12 files changed, 157 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthew Denton, +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages