[remoting]: Fix Yoda-style asserts in protocol tests [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Apr 1, 2026, 1:08:22 PM (2 days ago) Apr 1
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 1, 2026, 2:41:24 PM (2 days ago) Apr 1
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 1, 2026, 2:48:56 PM (2 days ago) Apr 1
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 1, 2026, 2:57:48 PM (2 days ago) Apr 1
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[remoting]: Fix Yoda-style asserts in protocol tests
This CL flips the arguments of EXPECT_EQ/ASSERT_EQ in remoting/protocol/*test.cc
from (expected, actual) to the more natural (actual, expected) format.
Change-Id: Idb82a613d37d4310faff34da41061e801fc958c9
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608697}
Files:
- M remoting/protocol/channel_multiplexer_unittest.cc
- M remoting/protocol/channel_socket_adapter_unittest.cc
- M remoting/protocol/chromium_socket_factory_unittest.cc
- M remoting/protocol/client_video_dispatcher_unittest.cc
- M remoting/protocol/connection_unittest.cc
- M remoting/protocol/ice_config_unittest.cc
- M remoting/protocol/ice_transport_unittest.cc
- M remoting/protocol/input_event_tracker_unittest.cc
- M remoting/protocol/jingle_session_unittest.cc
- M remoting/protocol/message_decoder_unittest.cc
- M remoting/protocol/message_reader_unittest.cc
- M remoting/protocol/negotiating_authenticator_unittest.cc
- M remoting/protocol/pairing_registry_unittest.cc
- M remoting/protocol/pseudo_tcp_unittest.cc
- M remoting/protocol/pseudotcp_adapter_unittest.cc
- M remoting/protocol/sdp_message_unittest.cc
- M remoting/protocol/spake2_authenticator_unittest.cc
- M remoting/protocol/validating_authenticator_unittest.cc
- M remoting/protocol/webrtc_audio_source_adapter_unittest.cc
- M remoting/protocol/webrtc_frame_scheduler_unittest.cc
- M remoting/protocol/webrtc_transport_unittest.cc
- M remoting/protocol/webrtc_video_frame_adapter_unittest.cc
Change size: L
Delta: 22 files changed, 188 insertions(+), 190 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages