[remoting]: Fix Yoda-style asserts in protocol tests [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
Apr 1, 2026, 1:08:22 PM (2 days ago) Apr 1
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb82a613d37d4310faff34da41061e801fc958c9
Gerrit-Change-Number: 7719711
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 17:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
Apr 1, 2026, 2:41:24 PM (2 days ago) Apr 1
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb82a613d37d4310faff34da41061e801fc958c9
    Gerrit-Change-Number: 7719711
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Joe Downing <joe...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 18:41:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Joe Downing (Gerrit)

    unread,
    Apr 1, 2026, 2:48:56 PM (2 days ago) Apr 1
    to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

    Joe Downing voted and added 1 comment

    Votes added by Joe Downing

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Joe Downing . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb82a613d37d4310faff34da41061e801fc958c9
    Gerrit-Change-Number: 7719711
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 18:48:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 2:57:48 PM (2 days ago) Apr 1
    to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [remoting]: Fix Yoda-style asserts in protocol tests

    This CL flips the arguments of EXPECT_EQ/ASSERT_EQ in remoting/protocol/*test.cc
    from (expected, actual) to the more natural (actual, expected) format.
    Change-Id: Idb82a613d37d4310faff34da41061e801fc958c9
    Reviewed-by: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1608697}
    Files:
    • M remoting/protocol/channel_multiplexer_unittest.cc
    • M remoting/protocol/channel_socket_adapter_unittest.cc
    • M remoting/protocol/chromium_socket_factory_unittest.cc
    • M remoting/protocol/client_video_dispatcher_unittest.cc
    • M remoting/protocol/connection_unittest.cc
    • M remoting/protocol/ice_config_unittest.cc
    • M remoting/protocol/ice_transport_unittest.cc
    • M remoting/protocol/input_event_tracker_unittest.cc
    • M remoting/protocol/jingle_session_unittest.cc
    • M remoting/protocol/message_decoder_unittest.cc
    • M remoting/protocol/message_reader_unittest.cc
    • M remoting/protocol/negotiating_authenticator_unittest.cc
    • M remoting/protocol/pairing_registry_unittest.cc
    • M remoting/protocol/pseudo_tcp_unittest.cc
    • M remoting/protocol/pseudotcp_adapter_unittest.cc
    • M remoting/protocol/sdp_message_unittest.cc
    • M remoting/protocol/spake2_authenticator_unittest.cc
    • M remoting/protocol/validating_authenticator_unittest.cc
    • M remoting/protocol/webrtc_audio_source_adapter_unittest.cc
    • M remoting/protocol/webrtc_frame_scheduler_unittest.cc
    • M remoting/protocol/webrtc_transport_unittest.cc
    • M remoting/protocol/webrtc_video_frame_adapter_unittest.cc
    Change size: L
    Delta: 22 files changed, 188 insertions(+), 190 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuwei Huang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb82a613d37d4310faff34da41061e801fc958c9
    Gerrit-Change-Number: 7719711
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages