[Cast Receiver] Connect input channels in StreamingRuntimeApplication [chromium/src : main]

0 views
Skip to first unread message

Simeon Anfinrud (Gerrit)

unread,
Jun 22, 2026, 1:15:47 PM (7 days ago) Jun 22
to Dewita Sonya, Shawn Quereshi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, halliwe...@chromium.org, inca-eng...@google.com
Attention needed from Dewita Sonya and Shawn Quereshi

Simeon Anfinrud voted and added 3 comments

Votes added by Simeon Anfinrud

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

lgtm % nits

File components/cast_receiver/browser/streaming_receiver_channel.cc
Line 22, Patchset 6 (Latest): DCHECK(message_port_service);
Simeon Anfinrud . unresolved

nit: chromium code has been preferring CHECKs to DCHECKs for a while (prioritizing memory safety over microscopic performance gains when we're not in hot loops).

File components/cast_receiver/browser/streaming_runtime_application_unittest.cc
Line 68, Patchset 6 (Latest): void SetUp() override {
Simeon Anfinrud . unresolved

nit: `SetUp()` logic can usually go in the constructor and `TearDown()` logic can usually go in the destructor.

Open in Gerrit

Related details

Attention is currently required from:
  • Dewita Sonya
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69f7ba9a68401e7464195071d4dcaaccb4db8ca1
Gerrit-Change-Number: 7962739
Gerrit-PatchSet: 6
Gerrit-Owner: Dewita Sonya <dso...@google.com>
Gerrit-Reviewer: Dewita Sonya <dso...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Dewita Sonya <dso...@google.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 17:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simeon Anfinrud (Gerrit)

unread,
Jun 25, 2026, 7:51:16 PM (3 days ago) Jun 25
to Dewita Sonya, Shawn Quereshi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, halliwe...@chromium.org, inca-eng...@google.com
Attention needed from Dewita Sonya and Shawn Quereshi

Simeon Anfinrud voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dewita Sonya
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69f7ba9a68401e7464195071d4dcaaccb4db8ca1
Gerrit-Change-Number: 7962739
Gerrit-PatchSet: 7
Gerrit-Owner: Dewita Sonya <dso...@google.com>
Gerrit-Reviewer: Dewita Sonya <dso...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Dewita Sonya <dso...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 23:51:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dewita Sonya (Gerrit)

unread,
Jun 25, 2026, 7:51:51 PM (3 days ago) Jun 25
to Simeon Anfinrud, Shawn Quereshi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, halliwe...@chromium.org, inca-eng...@google.com
Attention needed from Shawn Quereshi

Dewita Sonya added 2 comments

File components/cast_receiver/browser/streaming_receiver_channel.cc
Line 22, Patchset 6: DCHECK(message_port_service);
Simeon Anfinrud . resolved

nit: chromium code has been preferring CHECKs to DCHECKs for a while (prioritizing memory safety over microscopic performance gains when we're not in hot loops).

Dewita Sonya

Done

File components/cast_receiver/browser/streaming_runtime_application_unittest.cc
Line 68, Patchset 6: void SetUp() override {
Simeon Anfinrud . resolved

nit: `SetUp()` logic can usually go in the constructor and `TearDown()` logic can usually go in the destructor.

Dewita Sonya

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Shawn Quereshi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I69f7ba9a68401e7464195071d4dcaaccb4db8ca1
    Gerrit-Change-Number: 7962739
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dewita Sonya <dso...@google.com>
    Gerrit-Reviewer: Dewita Sonya <dso...@google.com>
    Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
    Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Attention: Shawn Quereshi <sha...@google.com>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 23:51:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Simeon Anfinrud <san...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages