[MAGI] Relocate magi-mode to agents/skills [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Jun 17, 2026, 6:08:38 PM (11 days ago) Jun 17
to Yuwei Huang, Struan Shrimpton, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org
Attention needed from Struan Shrimpton and Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Joe Downing . resolved
Adding Yuwei (SKILL co-owner) and Struan for review, PTAL!
Related details
Attention is currently required from:
- Struan Shrimpton
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 17, 2026, 6:26:21 PM (11 days ago) Jun 17
to Joe Downing, Struan Shrimpton, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org
Attention needed from Joe Downing and Struan Shrimpton
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File agents/skills/magi-mode/.gitignore
Line 8, Patchset 7 (Latest):
.temp/Yuwei Huang . unresolved
No action required for this CL, and you can do it in a separate CL. Jetski has the concept of a per-session brain directory, so it would be nice if MAGI creates temp files in that directory, but I'm fine with using `.temp/` as a fallback.
Related details
Attention is currently required from:
- Joe Downing
- Struan Shrimpton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Jun 17, 2026, 6:44:46 PM (11 days ago) Jun 17
to Yuwei Huang, Struan Shrimpton, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org
Attention needed from Struan Shrimpton
Joe Downing added 1 comment![]( "Open in Gerrit")
File agents/skills/magi-mode/.gitignore
Yuwei Huang . resolved
No action required for this CL, and you can do it in a separate CL. Jetski has the concept of a per-session brain directory, so it would be nice if MAGI creates temp files in that directory, but I'm fine with using `.temp/` as a fallback.
Joe Downing
sgtm, I want to keep the SKILL harness agnostic but that sounds like a good optimization for a follow-up.
Related details
Attention is currently required from:
- Struan Shrimpton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Struan Shrimpton (Gerrit)
Jun 18, 2026, 7:15:58 PM (10 days ago) Jun 18
to Joe Downing, Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org
Attention needed from Joe Downing
Struan Shrimpton voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Jun 18, 2026, 7:19:20 PM (10 days ago) Jun 18
to Struan Shrimpton, Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 7:29:07 PM (10 days ago) Jun 18
to Joe Downing, Struan Shrimpton, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[MAGI] Relocate magi-mode to agents/skills
This SKILL has been used internally by the Chromoting team for a few weeks now and has shown to generate higher quality code than using a
standard coding agent. The SKILL was generalized so it is not //remoting
specific and can now be used by any Chromie which would like to use it
on their code.
Change-Id: Idb0c6e8f0a1b11d33a5e6997ca019a28f63629f5
Reviewed-by: Struan Shrimpton <ssh...@google.com>
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649386}
Files:
- A agents/skills/magi-mode/.gitignore
- R agents/skills/magi-mode/.style.mdformat
- R agents/skills/magi-mode/.style.yapf
- R agents/skills/magi-mode/EXAMPLES.md
- A agents/skills/magi-mode/OWNERS
- R agents/skills/magi-mode/PRESUBMIT.py
- R agents/skills/magi-mode/PRESUBMIT_test.py
- R agents/skills/magi-mode/README.md
- R agents/skills/magi-mode/ROUTING.md
- R agents/skills/magi-mode/SKILL.md
- R agents/skills/magi-mode/SKILL_TEST.md
- R agents/skills/magi-mode/SKILL_TEST_PLAN.md
- R agents/skills/magi-mode/check_json_format.py
- R agents/skills/magi-mode/magi_schema.json
- R agents/skills/magi-mode/personas/ai/llm.json
- R agents/skills/magi-mode/personas/ai/mas.json
- R agents/skills/magi-mode/personas/auxiliary/build.json
- R agents/skills/magi-mode/personas/auxiliary/concurrency.json
- R agents/skills/magi-mode/personas/auxiliary/i18n.json
- R agents/skills/magi-mode/personas/auxiliary/privacy.json
- R agents/skills/magi-mode/personas/auxiliary/readability.json
- R agents/skills/magi-mode/personas/auxiliary/test.json
- R agents/skills/magi-mode/personas/chromeos/chromeos.json
- R agents/skills/magi-mode/personas/core/auditor.json
- R agents/skills/magi-mode/personas/core/gtest.json
- R agents/skills/magi-mode/personas/core/implementation.json
- R agents/skills/magi-mode/personas/core/performance.json
- R agents/skills/magi-mode/personas/core/scoping.json
- R agents/skills/magi-mode/personas/core/security.json
- R agents/skills/magi-mode/personas/core/test_infra.json
- R agents/skills/magi-mode/personas/domain/codec_av1.json
- R agents/skills/magi-mode/personas/domain/webrtc.json
- R agents/skills/magi-mode/personas/external/base_library.json
- R agents/skills/magi-mode/personas/external/webrtc_external.json
- R agents/skills/magi-mode/personas/infra/chromium_build.json
- R agents/skills/magi-mode/personas/infra/jj_git.json
- R agents/skills/magi-mode/personas/languages/c++.json
- R agents/skills/magi-mode/personas/languages/gn.json
- R agents/skills/magi-mode/personas/languages/markdown.json
- R agents/skills/magi-mode/personas/languages/objc.json
- R agents/skills/magi-mode/personas/languages/python.json
- R agents/skills/magi-mode/personas/linux/linux.json
- R agents/skills/magi-mode/personas/linux/wayland.json
- R agents/skills/magi-mode/personas/mac/mac_host.json
- R agents/skills/magi-mode/personas/remoting/base.json
- R agents/skills/magi-mode/personas/remoting/client.json
- R agents/skills/magi-mode/personas/remoting/codec.json
- R agents/skills/magi-mode/personas/remoting/host.json
- R agents/skills/magi-mode/personas/remoting/i18n.json
- R agents/skills/magi-mode/personas/remoting/it2me.json
- R agents/skills/magi-mode/personas/remoting/me2me.json
- R agents/skills/magi-mode/personas/remoting/multi_process.json
- R agents/skills/magi-mode/personas/remoting/native_messaging.json
- R agents/skills/magi-mode/personas/remoting/proto.json
- R agents/skills/magi-mode/personas/remoting/protocol.json
- R agents/skills/magi-mode/personas/remoting/robot_account.json
- R agents/skills/magi-mode/personas/remoting/signaling.json
- R agents/skills/magi-mode/personas/windows/file_api.json
- R agents/skills/magi-mode/personas/windows/windows_com.json
- R agents/skills/magi-mode/personas/windows/windows_host.json
- R agents/skills/magi-mode/personas/windows/windows_installer.json
- R agents/skills/magi-mode/run_magi_tests.py
- R agents/skills/magi-mode/run_presubmit.py
- R agents/skills/magi-mode/tests/magi_stage_generate_tests.json
- R agents/skills/magi-mode/tests/magi_stage_refine_tests.json
- R agents/skills/magi-mode/tests/magi_stage_specify_tests.json
- R agents/skills/magi-mode/tests/magi_test_schemas.json
- R agents/skills/magi-mode/tests/testdata/BUILD.gn
- R agents/skills/magi-mode/tests/testdata/complex_uaf.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/complex_uaf.h.magi.test
- R agents/skills/magi-mode/tests/testdata/file1.cc
- R agents/skills/magi-mode/tests/testdata/linux_fd_leak.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/linux_fd_leak.h.magi.test
- R agents/skills/magi-mode/tests/testdata/mac_retain_cycle.h.magi.test
- R agents/skills/magi-mode/tests/testdata/mac_retain_cycle.mm.magi.test
- R agents/skills/magi-mode/tests/testdata/mock_app.cc
- R agents/skills/magi-mode/tests/testdata/project.magi.json
- R agents/skills/magi-mode/tests/testdata/sample_ipc.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/state_block.magi.json
- R agents/skills/magi-mode/tests/testdata/strip_magi_comments.py
- R agents/skills/magi-mode/tests/testdata/tautological_assert_test.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/unsafe_casting.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/unsafe_casting.h.magi.test
- R agents/skills/magi-mode/tests/testdata/unsafe_threading.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/unsafe_threading.h.magi.test
- R agents/skills/magi-mode/tests/testdata/win_handle_leak.cc.magi.test
- R agents/skills/magi-mode/tests/testdata/win_handle_leak.h.magi.test
Change size: L
Delta: 87 files changed, 165 insertions(+), 131 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang, +1 by Struan Shrimpton
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages