Thomas Anderson (Gerrit)

unread,

Feb 18, 2026, 2:53:45 PM (3 days ago) Feb 18

to Avi Drissman, Chromium UI Views Reviews, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Avi Drissman, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman and Lambros Lambrou

Thomas Anderson added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Thomas Anderson . resolved

reviewers ptal.

avi:
  chrome/browser/ash/policy/dlp/data_transfer_dlp_controller_ash_browsertest.cc
  chrome/browser/chromeos/policy/dlp/data_transfer_dlp_controller_browsertest.cc
  chrome/browser/headless/headless_mode_browsertest.cc
  chrome/browser/renderer_context_menu/link_to_text_menu_observer_interactive_uitest.cc
  chrome/browser/sharing/shared_clipboard/shared_clipboard_test_base.cc
  chrome/browser/ui/views/sharing/remote_copy_browsertest.cc
  content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
  content/public/test/browser_test_utils.cc
  ui/base/clipboard/clipboard.cc
  ui/base/clipboard/clipboard.h
  ui/base/clipboard/clipboard_non_backed_unittest.cc
  ui/base/clipboard/clipboard_test_template.h
  ui/base/clipboard/clipboard_win_unittest.cc
chromium-ui-...@google.com:
  ui/views/controls/label_unittest.cc
  ui/views/controls/textfield/textfield_model_unittest.cc
  ui/views/controls/textfield/textfield_unittest.cc
  ui/views/view_unittest.cc
blundell:
  ash/quick_insert/quick_insert_test_util.cc
  chrome/browser/ash/policy/dlp/data_transfer_dlp_controller_ash_browsertest.cc
  chrome/browser/chromeos/policy/dlp/data_transfer_dlp_controller_browsertest.cc
  chrome/browser/headless/headless_mode_browsertest.cc
  chrome/browser/renderer_context_menu/link_to_text_menu_observer_interactive_uitest.cc
  chrome/browser/sharing/shared_clipboard/shared_clipboard_test_base.cc
  chrome/browser/ui/views/sharing/remote_copy_browsertest.cc
  components/exo/seat_unittest.cc
  ui/base/clipboard/clipboard.cc
  ui/base/clipboard/clipboard.h
  ui/base/clipboard/clipboard_non_backed_unittest.cc
  ui/base/clipboard/clipboard_test_template.h
  ui/base/clipboard/clipboard_win_unittest.cc
lambroslambrou:
  remoting/host/chromeos/clipboard_aura_unittest.cc
dgozman:
  chrome/browser/headless/headless_mode_browsertest.cc
  content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
  content/public/test/browser_test_utils.cc
  headless/test/headless_browser_browsertest.cc

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Chromium UI Views Reviews
Colin Blundell
Dmitry Gozman
Lambros Lambrou

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Feb 18, 2026, 2:59:03 PM (3 days ago) Feb 18

to Thomas Anderson, Chromium UI Views Reviews, Elly FJ, Avi Drissman, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Avi Drissman, Colin Blundell, Dmitry Gozman, Elly FJ and Lambros Lambrou

Message from gwsq

Reviewer source(s):
elly...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Colin Blundell
Dmitry Gozman
Elly FJ
Lambros Lambrou

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Feb 18, 2026, 2:59:31 PM (3 days ago) Feb 18

to Thomas Anderson, Chromium UI Views Reviews, Elly FJ, Avi Drissman, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman, Elly FJ, Lambros Lambrou and Thomas Anderson

Avi Drissman added 1 comment

File ui/base/clipboard/clipboard.cc

Line 40, Patchset 5 (Latest):

void SyncReadTestHelper(base::OnceClosure quit_closure, T* out, T result) {
  if (out) {
    *out = std::move(result);
  }
  std::move(quit_closure).Run();

Avi Drissman . unresolved

Can we use `base::test::TestFuture` instead? That is a one liner (allocate the future, make the call, call `Get()` and will replace all the RunLoop code.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dmitry Gozman
Elly FJ
Lambros Lambrou

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

satisfied_requirement

unsatisfied_requirement

open

diffy

Elly FJ (Gerrit)

unread,

Feb 18, 2026, 3:25:58 PM (3 days ago) Feb 18

to Thomas Anderson, Elly FJ, AyeAye, Chromium UI Views Reviews, Avi Drissman, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman, Lambros Lambrou and Thomas Anderson

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Elly FJ . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dmitry Gozman
Lambros Lambrou
Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Feb 18, 2026, 3:32:33 PM (3 days ago) Feb 18

to Elly FJ, AyeAye, Chromium UI Views Reviews, Avi Drissman, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Avi Drissman, Colin Blundell, Dmitry Gozman, Elly FJ and Lambros Lambrou

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Commit-Queue

+1

1 comment

File ui/base/clipboard/clipboard.cc

Line 40, Patchset 5:void SyncReadTestHelper(base::OnceClosure quit_closure, T* out, T result) {


  if (out) {
    *out = std::move(result);
  }
  std::move(quit_closure).Run();

Avi Drissman . resolved

Can we use `base::test::TestFuture` instead? That is a one liner (allocate the future, make the call, call `Get()` and will replace all the RunLoop code.

Thomas Anderson

I don't believe that's possible since `TestFuture` is part of `//base/test:test_support` which we cannot add a dependency on in this non-test target.

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Colin Blundell
Dmitry Gozman
Elly FJ
Lambros Lambrou

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Feb 18, 2026, 3:33:45 PM (3 days ago) Feb 18

to Thomas Anderson, Avi Drissman, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman, Elly FJ, Lambros Lambrou and Thomas Anderson

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Code-Review

+1

1 comment

File ui/base/clipboard/clipboard.cc

Line 40, Patchset 5:

void SyncReadTestHelper(base::OnceClosure quit_closure, T* out, T result) {
  if (out) {
    *out = std::move(result);
  }
  std::move(quit_closure).Run();

Avi Drissman . resolved

Can we use `base::test::TestFuture` instead? That is a one liner (allocate the future, make the call, call `Get()` and will replace all the RunLoop code.

Thomas Anderson

I don't believe that's possible since `TestFuture` is part of `//base/test:test_support` which we cannot add a dependency on in this non-test target.

Avi Drissman

That is incredibly unfortunate. Can we spin off these SyncForTest functions into a test-only file?

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dmitry Gozman
Elly FJ
Lambros Lambrou

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Feb 18, 2026, 3:41:27 PM (3 days ago) Feb 18

to Thomas Anderson, Avi Drissman, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Lambros Lambrou, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman, Elly FJ, Lambros Lambrou and Thomas Anderson

Avi Drissman added 1 comment

File ui/base/clipboard/clipboard.cc

Line 40, Patchset 5:

void SyncReadTestHelper(base::OnceClosure quit_closure, T* out, T result) {
  if (out) {
    *out = std::move(result);
  }
  std::move(quit_closure).Run();

Avi Drissman . resolved

Can we use `base::test::TestFuture` instead? That is a one liner (allocate the future, make the call, call `Get()` and will replace all the RunLoop code.

Thomas Anderson

I don't believe that's possible since `TestFuture` is part of `//base/test:test_support` which we cannot add a dependency on in this non-test target.

Avi Drissman

That is incredibly unfortunate. Can we spin off these SyncForTest functions into a test-only file?

Avi Drissman

Or at least note why we don’t use it.

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Feb 18, 2026, 3:41:58 PM (3 days ago) Feb 18

to Thomas Anderson, Avi Drissman, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman, Elly FJ and Thomas Anderson

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Lambros Lambrou . resolved

remoting LGTM

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dmitry Gozman
Elly FJ

Thomas Anderson

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Feb 18, 2026, 5:07:46 PM (3 days ago) Feb 18

to Thomas Anderson, Avi Drissman, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Avi Drissman, Colin Blundell, Dmitry Gozman, Elly FJ and Thomas Anderson

Lambros Lambrou voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Colin Blundell
Dmitry Gozman
Elly FJ
Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Feb 18, 2026, 6:56:58 PM (3 days ago) Feb 18

to Thomas Anderson, Avi Drissman, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Avi Drissman, Colin Blundell, Dmitry Gozman, Elly FJ and Thomas Anderson

Lambros Lambrou voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Colin Blundell
Dmitry Gozman
Elly FJ
Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Feb 18, 2026, 7:33:43 PM (3 days ago) Feb 18

to Lambros Lambrou, Avi Drissman, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Avi Drissman, Colin Blundell, Dmitry Gozman, Elly FJ and Thomas Anderson

Thomas Anderson added 2 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Thomas Anderson . resolved

sorry for the noise. ellyjones/avi/lambroslambrou please approve again as your +1's have been lost

File ui/base/clipboard/clipboard.cc

Line 40, Patchset 5:

void SyncReadTestHelper(base::OnceClosure quit_closure, T* out, T result) {
  if (out) {
    *out = std::move(result);
  }
  std::move(quit_closure).Run();

Avi Drissman . resolved

Can we use `base::test::TestFuture` instead? That is a one liner (allocate the future, make the call, call `Get()` and will replace all the RunLoop code.

Thomas Anderson

I don't believe that's possible since `TestFuture` is part of `//base/test:test_support` which we cannot add a dependency on in this non-test target.

Avi Drissman

That is incredibly unfortunate. Can we spin off these SyncForTest functions into a test-only file?

Avi Drissman

Or at least note why we don’t use it.

Thomas Anderson

I've rewritten this CL to move the test functions to ui/base/clipboard/test/clipboard_test_util.h

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Feb 19, 2026, 12:05:32 PM (2 days ago) Feb 19

to Thomas Anderson, Avi Drissman, Lambros Lambrou, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman, Elly FJ and Thomas Anderson

Avi Drissman voted and added 2 comments

Votes added by Avi Drissman

Code-Review

+1

2 comments

File ui/base/clipboard/clipboard.cc

File-level comment, Patchset 11 (Latest):

Avi Drissman . unresolved

The changes to this file can be reverted, then.

Line 40, Patchset 5:

void SyncReadTestHelper(base::OnceClosure quit_closure, T* out, T result) {
  if (out) {
    *out = std::move(result);
  }
  std::move(quit_closure).Run();

Avi Drissman . resolved

Can we use `base::test::TestFuture` instead? That is a one liner (allocate the future, make the call, call `Get()` and will replace all the RunLoop code.

Thomas Anderson

I don't believe that's possible since `TestFuture` is part of `//base/test:test_support` which we cannot add a dependency on in this non-test target.

Avi Drissman

That is incredibly unfortunate. Can we spin off these SyncForTest functions into a test-only file?

Avi Drissman

Or at least note why we don’t use it.

Thomas Anderson

I've rewritten this CL to move the test functions to ui/base/clipboard/test/clipboard_test_util.h

Avi Drissman

Excellent, thank you!

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dmitry Gozman
Elly FJ
Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Feb 19, 2026, 12:13:36 PM (2 days ago) Feb 19

to Avi Drissman, Lambros Lambrou, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Dmitry Gozman and Elly FJ

Thomas Anderson added 1 comment

File ui/base/clipboard/clipboard.cc

File-level comment, Patchset 11:

Avi Drissman . resolved

The changes to this file can be reverted, then.

Thomas Anderson

Done

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dmitry Gozman
Elly FJ

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Feb 19, 2026, 12:15:07 PM (2 days ago) Feb 19

to Peter Kvitek, Avi Drissman, Lambros Lambrou, Elly FJ, AyeAye, Chromium UI Views Reviews, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Colin Blundell, Elly FJ and Peter Kvitek

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Thomas Anderson . resolved

-dgozman is OOO
+kvitekp for //headless

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Elly FJ
Peter Kvitek

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Feb 19, 2026, 12:36:58 PM (2 days ago) Feb 19

to Thomas Anderson, Colin Blundell, Peter Kvitek, Avi Drissman, Lambros Lambrou, Elly FJ, AyeAye, Chromium UI Views Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Elly FJ, Peter Kvitek and Thomas Anderson

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Elly FJ
Peter Kvitek
Thomas Anderson

satisfied_requirement

unsatisfied_requirement

open

diffy

Elly FJ (Gerrit)

unread,

Feb 19, 2026, 12:46:32 PM (2 days ago) Feb 19

to Thomas Anderson, Elly FJ, Colin Blundell, Peter Kvitek, Avi Drissman, Lambros Lambrou, AyeAye, Chromium UI Views Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Peter Kvitek and Thomas Anderson

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Elly FJ . resolved

still lgtm :)

Open in Gerrit

Related details

Attention is currently required from:

Peter Kvitek
Thomas Anderson

satisfied_requirement

unsatisfied_requirement

open

diffy

Peter Kvitek (Gerrit)

unread,

Feb 19, 2026, 3:28:10 PM (2 days ago) Feb 19

to Thomas Anderson, Elly FJ, Colin Blundell, Avi Drissman, Lambros Lambrou, AyeAye, Chromium UI Views Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Attention needed from Thomas Anderson

Peter Kvitek voted and added 1 comment

Votes added by Peter Kvitek

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Peter Kvitek . resolved

lgtm headless

Open in Gerrit

Related details

Attention is currently required from:

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners

satisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Feb 19, 2026, 5:11:48 PM (2 days ago) Feb 19

to Peter Kvitek, Elly FJ, Colin Blundell, Avi Drissman, Lambros Lambrou, AyeAye, Chromium UI Views Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Thomas Anderson voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 19, 2026, 5:15:07 PM (2 days ago) Feb 19

to Thomas Anderson, Peter Kvitek, Elly FJ, Colin Blundell, Avi Drissman, Lambros Lambrou, AyeAye, Chromium UI Views Reviews, chromium...@chromium.org, chromotin...@chromium.org, Enterprise Policy Reviews, James Su, ajayramamurth...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, dtraino...@chromium.org, chlily...@chromium.org, xinghui...@chromium.org, druber...@chromium.org, mac-r...@chromium.org, alexmo...@chromium.org, cbe-cep-eng...@google.com, creis...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Add Clipboard::Read*SyncForTest and replace sync calls in tests

The synchronous clipboard methods are deprecated, however syncing is
still acceptable in tests, so this CL adds test-only sync methods so
that the sync implementations can eventually be removed.

Bug: 40398800

Change-Id: Ide7824cd80fac688a6e452707f99e10ad3287a34

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7586395

Reviewed-by: Colin Blundell <blun...@chromium.org>

Reviewed-by: Avi Drissman <a...@chromium.org>

Reviewed-by: Lambros Lambrou <lambros...@chromium.org>

Commit-Queue: Thomas Anderson <thomasa...@chromium.org>

Reviewed-by: Peter Kvitek <kvi...@chromium.org>

Reviewed-by: Elly FJ <elly...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1587412}

Files:

M ash/BUILD.gn
M ash/lobster/lobster_image_insert_or_copy_actuator_unittest.cc
M ash/quick_insert/quick_insert_test_util.cc
M chrome/browser/ash/policy/dlp/BUILD.gn
M chrome/browser/ash/policy/dlp/data_transfer_dlp_controller_ash_browsertest.cc
M chrome/browser/ash/sharesheet/copy_to_clipboard_share_action_unittest.cc
M chrome/browser/chromeos/policy/dlp/BUILD.gn
M chrome/browser/chromeos/policy/dlp/data_transfer_dlp_controller_browsertest.cc
M chrome/browser/headless/BUILD.gn
M chrome/browser/headless/headless_mode_browsertest.cc
M chrome/browser/nearby_sharing/nearby_notification_manager_unittest.cc
M chrome/browser/renderer_context_menu/link_to_text_menu_observer_interactive_uitest.cc
M chrome/browser/sharing/shared_clipboard/shared_clipboard_test_base.cc
M chrome/browser/ui/views/download/bubble/download_bubble_row_view_unittest.cc
M chrome/browser/ui/views/sharing/remote_copy_browsertest.cc
M components/exo/BUILD.gn
M components/exo/seat_unittest.cc
M content/browser/renderer_host/clipboard_host_impl.cc
M content/browser/renderer_host/clipboard_host_impl_browsertest.cc
M content/browser/renderer_host/clipboard_host_impl_unittest.cc
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
M content/public/test/browser_test_utils.cc
M headless/BUILD.gn
M headless/test/headless_browser_browsertest.cc
M remoting/host/chromeos/BUILD.gn
M remoting/host/chromeos/clipboard_aura_unittest.cc
M ui/base/clipboard/clipboard.cc
M ui/base/clipboard/clipboard_non_backed_unittest.cc
M ui/base/clipboard/clipboard_test_template.h
M ui/base/clipboard/clipboard_win_unittest.cc
M ui/base/clipboard/test/clipboard_test_util.cc
M ui/base/clipboard/test/clipboard_test_util.h
M ui/views/controls/label_unittest.cc
M ui/views/controls/textfield/textfield_model_unittest.cc
M ui/views/controls/textfield/textfield_unittest.cc
M ui/views/view_unittest.cc

Change size: XL

Delta: 36 files changed, 668 insertions(+), 501 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Colin Blundell, +1 by Peter Kvitek, +1 by Lambros Lambrou, +1 by Elly FJ, +1 by Avi Drissman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Add Clipboard::Read*SyncForTest and replace sync calls in tests [chromium/src : main]

Thomas Anderson (Gerrit)

Thomas Anderson added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Avi Drissman (Gerrit)

Avi Drissman added 1 comment

Related details

Elly FJ (Gerrit)

Elly FJ voted and added 1 comment

Votes added by Elly FJ

1 comment

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

1 comment

Related details

Avi Drissman (Gerrit)

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

1 comment

Related details

Avi Drissman (Gerrit)

Avi Drissman added 1 comment

Lambros Lambrou (Gerrit)

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

1 comment

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted Code-Review+1

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted Code-Review+1

Related details

Thomas Anderson (Gerrit)

Thomas Anderson added 2 comments

Avi Drissman (Gerrit)

Avi Drissman voted and added 2 comments

Votes added by Avi Drissman

2 comments

Related details

Thomas Anderson (Gerrit)

Thomas Anderson added 1 comment

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

1 comment

Related details

Elly FJ (Gerrit)

Elly FJ voted and added 1 comment

Votes added by Elly FJ

1 comment

Related details

Peter Kvitek (Gerrit)

Peter Kvitek voted and added 1 comment

Votes added by Peter Kvitek

1 comment

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information