Replace XmlElement usage in various jingle classes [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Feb 12, 2026, 4:09:45 PM (9 days ago) Feb 12
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 12, 2026, 5:24:33 PM (9 days ago) Feb 12
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 12, 2026, 7:09:24 PM (9 days ago) Feb 12
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 12, 2026, 7:28:04 PM (9 days ago) Feb 12
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Replace XmlElement usage in various jingle classes
This change replaces a number of XmlElement usages in misc.
classes and usages with a well-formed struct so the final _legacy
XmlElement member of JingleMessage can be removed.
Bug: 359620500
Change-Id: I613f0f6f0962e68d4bb8aff1e76cce6de8153074
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1584322}
Files:
- M remoting/protocol/jingle_message_xml_converter.cc
- M remoting/protocol/jingle_message_xml_converter.h
- M remoting/protocol/jingle_messages.cc
- M remoting/protocol/jingle_messages.h
- M remoting/protocol/jingle_messages_unittest.cc
Change size: M
Delta: 5 files changed, 84 insertions(+), 32 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages