remoting Linux multi-process: Fix ChromotingHostServices [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Mar 30, 2026, 5:14:24 PM (4 days ago) Mar 30
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 30, 2026, 7:02:18 PM (4 days ago) Mar 30
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Code-Review | +1 |
1 comment
File remoting/host/chromoting_host_services_server.cc
Line 60, Patchset 9 (Latest):
// legacy simngle-process host, the server is run as the login user.Joe Downing . unresolved
single
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 30, 2026, 7:19:28 PM (4 days ago) Mar 30
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/host/chromoting_host_services_server.cc
Line 60, Patchset 9:
// legacy simngle-process host, the server is run as the login user.Joe Downing . resolved
Yuwei Huangsingle
Oops! Done :)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 30, 2026, 8:10:04 PM (4 days ago) Mar 30
to Yuwei Huang, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/host/chromoting_host_services_server.cc
Insertions: 1, Deletions: 1.
@@ -57,7 +57,7 @@
: ChromotingHostServicesServer(
#if BUILDFLAG(IS_LINUX)
// For the multi-process host, the server is run as root; for the
- // legacy simngle-process host, the server is run as the login user.
+ // legacy single-process host, the server is run as the login user.
(getuid() == 0) ? GetChromotingHostServicesServerName()
: GetLegacyChromotingHostServicesServerName(),
#else
```
Change information
Commit message:
remoting Linux multi-process: Fix ChromotingHostServices
The single-process host uses `chromoting.$USER.host_services_mojo_ipc`
as the socket name due to multi-user support, but for the multi-process
host, the socket is created by the daemon process, which is run as
root, so this doesn't work. This CL fixes this by making the IPC server
in the daemon process use `chromoting.host_services_mojo_ipc` as the IPC
name. Since the client doesn't know if the host is single- or
multi-process, it is updated to try both socket names and see which one
works.
This is not done yet. In the next CL, I'll hook
DaemonProcessLinux::BindChromotingHostServices into
DesktopSessionFactoryLinux so that a request can be routed to the
correct user/desktop session.
Bug: 492619234
Change-Id: I378d80809d54399739fcc452cbbb94f47bbb0dd2
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607491}
Files:
- M remoting/host/chromoting_host_services_client.cc
- M remoting/host/chromoting_host_services_client.h
- M remoting/host/chromoting_host_services_server.cc
- M remoting/host/ipc_constants.cc
- M remoting/host/ipc_constants.h
Change size: M
Delta: 5 files changed, 107 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages