Add remoting_unittests and vr_common_unittests to linux-arm64 FYI bots [chromium/src : main]
0 views
Skip to first unread message
Thomas Anderson (Gerrit)
Apr 20, 2026, 8:49:58 PM (3 days ago) Apr 20
to Lambros Lambrou, Reilly Grant, android-bu...@system.gserviceaccount.com, Ben Pastene, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Ben Pastene, Lambros Lambrou and Reilly Grant
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3:
Ben Pastene . resolved
Thomas Andersonlgtm but there are some build failures on the tryjobs here:
https://ci.chromium.org/ui/p/chromium/builders/try/linux-arm64-rel-fyi/13/infraIs the "remoting_unittests" target properly visible in a linux-arm64 build?
Oops, I forgot to enable remoting and VR in buildflags.
+additional reviewers ptal
lambroslambrou: remoting/remoting_enable.gni
reillyg: device/vr/buildflags/buildflags.gni
Related details
Attention is currently required from:
- Ben Pastene
- Lambros Lambrou
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 21, 2026, 11:16:26 AM (3 days ago) Apr 21
to Lambros Lambrou, Reilly Grant, android-bu...@system.gserviceaccount.com, Ben Pastene, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Ben Pastene, Lambros Lambrou and Reilly Grant
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Ben Pastene . resolved
Thomas Andersonlgtm but there are some build failures on the tryjobs here:
https://ci.chromium.org/ui/p/chromium/builders/try/linux-arm64-rel-fyi/13/infraIs the "remoting_unittests" target properly visible in a linux-arm64 build?
Oops, I forgot to enable remoting and VR in buildflags.
+additional reviewers ptal
lambroslambrou: remoting/remoting_enable.gni
reillyg: device/vr/buildflags/buildflags.gni
Thomas Anderson
The build succeeds and those test suites now pass on the linux-arm64 bots.
Ben Pastene (Gerrit)
Apr 21, 2026, 11:18:18 AM (3 days ago) Apr 21
to Thomas Anderson, Lambros Lambrou, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Lambros Lambrou, Reilly Grant and Thomas Anderson
Ben Pastene voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lambros Lambrou
- Reilly Grant
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Apr 21, 2026, 1:35:38 PM (3 days ago) Apr 21
to Thomas Anderson, Ben Pastene, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Reilly Grant and Thomas Anderson
Lambros Lambrou voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Reilly Grant
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 22, 2026, 12:16:45 PM (2 days ago) Apr 22
to Lambros Lambrou, Ben Pastene, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Reilly Grant
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 23, 2026, 12:32:24 PM (17 hours ago) Apr 23
to Lambros Lambrou, Ben Pastene, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Reilly Grant
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Thomas Anderson . resolved
+blundell for //device
Thomas Anderson (Gerrit)
Apr 23, 2026, 12:32:55 PM (17 hours ago) Apr 23
to Matt Reynolds, Lambros Lambrou, Ben Pastene, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Matt Reynolds and Reilly Grant
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Matt Reynolds
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
Apr 23, 2026, 1:51:25 PM (16 hours ago) Apr 23
to Thomas Anderson, Reilly Grant, Matt Reynolds, Lambros Lambrou, Ben Pastene, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Matt Reynolds and Thomas Anderson
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Matt Reynolds
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 23, 2026, 3:51:43 PM (14 hours ago) Apr 23
to Reilly Grant, Matt Reynolds, Lambros Lambrou, Ben Pastene, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Attention needed from Matt Reynolds
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 23, 2026, 3:55:07 PM (14 hours ago) Apr 23
to Thomas Anderson, Reilly Grant, Matt Reynolds, Lambros Lambrou, Ben Pastene, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add remoting_unittests and vr_common_unittests to linux-arm64 FYI bots
This re-enables remoting_unittests and vr_common_unittests on the
linux-arm64-rel-fyi and linux-arm64-dbg-fyi builders because the
required dependency (libei) is now available for Linux arm64.
Change-Id: I9ffeeb690d94b830414ce4f49f1b36cf06b675cd
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Reviewed-by: Reilly Grant <rei...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Ben Pastene <bpas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619716}
Files:
- M device/vr/buildflags/buildflags.gni
- M infra/config/generated/builders/ci/linux-arm64-dbg-fyi/targets/chromium.fyi.json
- M infra/config/generated/builders/ci/linux-arm64-rel-fyi/targets/chromium.fyi.json
- M infra/config/generated/builders/try/linux-arm64-dbg-fyi/targets/chromium.fyi.json
- M infra/config/generated/builders/try/linux-arm64-rel-fyi/targets/chromium.fyi.json
- M infra/config/subprojects/chromium/ci/chromium.fyi.star
- M remoting/remoting_enable.gni
Change size: M
Delta: 7 files changed, 155 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Reilly Grant, +1 by Ben Pastene, +1 by Lambros Lambrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages