Add structured signaling protos for FTL [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
Jan 16, 2026, 7:05:45 PM (4 days ago) Jan 16
to Yuwei Huang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie2f70c0048ff85e5d29d422451e5f22cb899c1a1
Gerrit-Change-Number: 7489972
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Sat, 17 Jan 2026 00:05:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
Jan 16, 2026, 8:46:20 PM (4 days ago) Jan 16
to Joe Downing, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie2f70c0048ff85e5d29d422451e5f22cb899c1a1
    Gerrit-Change-Number: 7489972
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Joe Downing <joe...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 01:46:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Joe Downing (Gerrit)

    unread,
    Jan 16, 2026, 9:25:32 PM (4 days ago) Jan 16
    to Yuwei Huang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromotin...@chromium.org
    Attention needed from Joe Downing

    Joe Downing voted and added 1 comment

    Votes added by Joe Downing

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Joe Downing . resolved

    Thanks!

    Gerrit-Comment-Date: Sat, 17 Jan 2026 02:25:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 16, 2026, 9:28:31 PM (4 days ago) Jan 16
    to Joe Downing, Yuwei Huang, AyeAye, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add structured signaling protos for FTL

    This CL adds the structured xmpp and webrtc protos we will use to
    replace the serialized XML payloads we currently exchange over FTL.
    I will add some helper classes to convert between structured proto
    and XML strings in a follow-up CL.

    One aspect of this CL to call out is that the FTL protos currently
    use proto2 syntax so I've updated the fields to conform to the
    proto2 best practices.
    Bug: 359620500
    Change-Id: Ie2f70c0048ff85e5d29d422451e5f22cb899c1a1
    Reviewed-by: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570725}
    Files:
    • M remoting/proto/ftl/v1/BUILD.gn
    • M remoting/proto/ftl/v1/chromoting_message.proto
    • A remoting/proto/ftl/v1/webrtc.proto
    • A remoting/proto/ftl/v1/xmpp.proto
    Change size: L
    Delta: 4 files changed, 314 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuwei Huang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie2f70c0048ff85e5d29d422451e5f22cb899c1a1
    Gerrit-Change-Number: 7489972
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages