[remoting] Expand Engineering Manager checklist for reviewer selection [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
May 13, 2026, 12:08:29 AM (9 days ago) May 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
May 13, 2026, 3:36:22 AM (9 days ago) May 13
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 13, 2026, 9:36:36 AM (8 days ago) May 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 13, 2026, 9:49:22 AM (8 days ago) May 13
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[remoting] Expand Engineering Manager checklist for reviewer selection
Add items to the Engineering Manager checklist to ensure diverse and
thorough reviewer selection:
- Language expert (C++)
- Domain specialists
- Independent perspective (non-implementor)
- Mandate overlap for critical items
- Cross-component coverage
This aims to frontload quality and reduce review cycles.
TAG=agy
CONV=f8b5b5a4-cedd-4899-b83d-a3eff5d6de55
Change-Id: I1c7d26e2cafb94bf17144b7e35c7c0987cbbd49b
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1629933}
Files:
- M remoting/tools/magi-mode/personas/core/engineering_manager.json
Change size: XS
Delta: 1 file changed, 6 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 19, 2026, 2:18:19 PM (2 days ago) May 19
to android-bu...@system.gserviceaccount.com, chromotin...@chromium.org
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages