Add IqStanza proto converter class for FTL (and proto update) [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 9, 2026, 6:39:27 PM (5 days ago) Mar 9
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 9, 2026, 7:57:00 PM (5 days ago) Mar 9
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 9, 2026, 7:57:08 PM (5 days ago) Mar 9
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 9, 2026, 8:55:18 PM (5 days ago) Mar 9
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add IqStanza proto converter class for FTL (and proto update)
This change updates the XMPP proto to use a oneof field rather than
a type enum which simplifies the logic and prevents an enum naming
conflict on Windows. This is safe because nothing uses this proto
yet. I've also added a converter class and tests for the XMPP proto
messages for FTL. I will wait until branch point before hooking
them up so M147 will only operate on the serialized XML field and
we can ensure that code is stable before introducing more change.
Bug: 359620500
Change-Id: I02cbba600c9ca9ad97f5a7b0447cdab49b46e2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7648545
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1596749}
Files:
- M remoting/proto/ftl/v1/xmpp.proto
- M remoting/signaling/BUILD.gn
- M remoting/signaling/jingle_data_structures.cc
- M remoting/signaling/jingle_data_structures.h
- A remoting/signaling/jingle_message_proto_converter.cc
- A remoting/signaling/jingle_message_proto_converter.h
- A remoting/signaling/jingle_message_proto_converter_unittest.cc
Change size: L
Delta: 7 files changed, 460 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages