remoting: Fix potential UAF in GnomeDisplayConfigDBusClient [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
May 20, 2026, 8:03:09 PM (22 hours ago) May 20
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3bbf00a6196890cc5dae64e1048a4444a53e7ccf
Gerrit-Change-Number: 7866183
Gerrit-PatchSet: 3
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Thu, 21 May 2026 00:03:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
May 20, 2026, 8:15:47 PM (22 hours ago) May 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3bbf00a6196890cc5dae64e1048a4444a53e7ccf
    Gerrit-Change-Number: 7866183
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Thu, 21 May 2026 00:15:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 20, 2026, 11:51:00 PM (19 hours ago) May 20
    to Yuwei Huang, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    remoting: Fix potential UAF in GnomeDisplayConfigDBusClient

    Pass CallbackInfo holding WeakPtr and TaskRunner instead of raw 'this'
    pointer as user_data to asynchronous GLib D-Bus callbacks. This prevents
    Use-After-Free when the GnomeDisplayConfigDBusClient is destroyed before
    the callbacks fire.

    TAG=agy
    CONV=2205968e-bb7b-4a02-a47e-5b5ed1f30a1a
    Bug: 513727494
    Change-Id: I3bbf00a6196890cc5dae64e1048a4444a53e7ccf
    Reviewed-by: Joe Downing <joe...@chromium.org>
    Auto-Submit: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1634024}
    Files:
    • M remoting/host/linux/gnome_display_config_dbus_client.cc
    • M remoting/host/linux/gnome_display_config_dbus_client.h
    Change size: S
    Delta: 2 files changed, 21 insertions(+), 16 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joe Downing
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3bbf00a6196890cc5dae64e1048a4444a53e7ccf
    Gerrit-Change-Number: 7866183
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages