[crd host][linux] Allow run-multi-process-host script to keep sessions [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Mar 11, 2026, 3:07:47 AM (3 days ago) Mar 11
to Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Lambros Lambrou
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Lambros Lambrou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Mar 11, 2026, 12:12:04 PM (3 days ago) Mar 11
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Lambros Lambrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lambros Lambrou
| Code-Review | +1 |
1 comment
File remoting/tools/run_multi_process_host.py
Line 299, Patchset 1 (Latest):
"testing session recovery behavior. Run this script again as run with "
"the --terminate-sessions flag to terminate these sessions.")Lambros Lambrou . unresolved
nit: This sentence has extra words. Maybe: "Run this script with the --terminate-sessions flag..." or "Use the --terminate-sessions flag..."
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 11, 2026, 4:51:29 PM (3 days ago) Mar 11
to Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/tools/run_multi_process_host.py
Line 299, Patchset 1:
"testing session recovery behavior. Run this script again as run with "
"the --terminate-sessions flag to terminate these sessions.")Lambros Lambrou . resolved
nit: This sentence has extra words. Maybe: "Run this script with the --terminate-sessions flag..." or "Use the --terminate-sessions flag..."
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 11, 2026, 5:17:30 PM (3 days ago) Mar 11
to Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yuwei Huang . resolved
Trybots are stuck. I'm going to skip CQ since there is nothing buildable or testable for the script.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 11, 2026, 5:17:53 PM (3 days ago) Mar 11
to Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/tools/run_multi_process_host.py
Insertions: 2, Deletions: 2.
@@ -296,8 +296,8 @@
help=
"Skip terminating remote sessions on exit. Graphical sessions created "
"by CRD will be kept even after the host has exited. This allows for "
- "testing session recovery behavior. Run this script again as run with "
- "the --terminate-sessions flag to terminate these sessions.")
+ "testing session recovery behavior. Run this script as root with the "
+ "--terminate-sessions flag to terminate these sessions.")
parser.add_argument("--terminate-sessions",
action="store_true",
help="Only terminate remote sessions and exit. "
```
Change information
Commit message:
[crd host][linux] Allow run-multi-process-host script to keep sessions
Update the run_multi_process_host script so that:
remoting/tools/run_multi_process_host.py out/debug
Runs the host as usual and terminates sessions once host stops running
remoting/tools/run_multi_process_host.py out/debug --keep-sessions
Runs the host but does not terminate sessions once host stops running
sudo remoting/tools/run_multi_process_host.py --terminate-sessions
Terminates all CRD-managed sessions. No out-dir needed.
This is to allow testing desktop session recovery after the host process
has died or during host update.
Bug: 475611769
Change-Id: I64a6268bc4aa9aacea6a6f5ac15b17e7a65d4089
Auto-Submit: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597989}
Files:
- M remoting/tools/run_multi_process_host.py
Change size: S
Delta: 1 file changed, 35 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lambros Lambrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages