remoting: Remove legacy messaging components [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Apr 21, 2026, 3:15:22 AM (3 days ago) Apr 21
to Joe Downing, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 10:06:44 AM (3 days ago) Apr 21
to Yuwei Huang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 3:10:03 PM (3 days ago) Apr 21
to Joe Downing, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Yuwei Huang . resolved
CR vote reverted due to `remoting/host/input_injector_mac.cc` 😅 Please take another look, thanks!
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 3:11:30 PM (3 days ago) Apr 21
to Yuwei Huang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 3:11:56 PM (3 days ago) Apr 21
to Joe Downing, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 4:43:02 PM (3 days ago) Apr 21
to Yuwei Huang, Joe Downing, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
remoting: Remove legacy messaging components
Identify and remove dead code from the legacy non-WebRTC messaging
pipeline. This includes components used for framing and buffering
messages over stream sockets in the legacy Chromotocol architecture,
which are no longer needed for WebRTC-based communication.
Deleted files:
- remoting/base/buffered_socket_writer.cc/h/unittest.cc
- remoting/protocol/message_reader.cc/h/unittest.cc
- remoting/protocol/message_decoder.cc/h/unittest.cc
- remoting/protocol/message_serialization.cc
Also removed SerializeAndFrameMessage() from message_serialization.h,
while keeping ParseMessage() as it is still used by WebRTC dispatchers.
Bug: 375470501
Change-Id: I3e7b9dd474d4b60de7259ab3af2de7d6d7364b51
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Auto-Submit: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618413}
Files:
- M remoting/base/BUILD.gn
- D remoting/base/buffered_socket_writer.cc
- D remoting/base/buffered_socket_writer.h
- D remoting/base/buffered_socket_writer_unittest.cc
- M remoting/host/input_injector_mac.cc
- M remoting/protocol/BUILD.gn
- D remoting/protocol/message_decoder.cc
- D remoting/protocol/message_decoder.h
- D remoting/protocol/message_decoder_unittest.cc
- D remoting/protocol/message_reader.cc
- D remoting/protocol/message_reader.h
- D remoting/protocol/message_reader_unittest.cc
- D remoting/protocol/message_serialization.cc
- M remoting/protocol/message_serialization.h
Change size: XL
Delta: 14 files changed, 0 insertions(+), 1200 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages