LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) [chromium/src : master]
Yuta Hijikata (Gerrit)
1 comment:
Patchset:
Hi owners,
This is a mechanical change required by lacros project. It replaces defined(OS_CHROMEOS) macro with BUILDFLAG(IS_CHROMEOS_ASH) and is_chromeos gn variable with is_chromeos_ash.
Could you give it an owners approval? Or if you think you are not the right reviewer for this change, please add another reviewer.
For more details, please take a go/lacros-macros.
Thank you,
Yuta
To view, visit change 2532483. To unsubscribe, or for help writing mail filters, visit settings.
Joe Downing (Gerrit)
Attention is currently required from: Yuta Hijikata.
2 comments:
File remoting/BUILD.gn:
Patch Set #1, Line 180:
!is_chromeos_ashBased on the doc link in the cl description, this statement will eventually return back to '!is_chromeos' correct?
The reason I ask is that for our project, '!is_chromeos' means '!is_chromeos_ash && !is_chromeos_lacros' and I want to make sure that this will be preserved once the intermediate steps have been completed.
For example in this build file, we don't need the client/display targets or tests in ChromeOS (either current impl or ash/lacros). Temporarily building them for is_chromeos_lacros is fine but I don't think we want that longer-term (it would mean additional, unnecessary build work since we don't use those components on that platform).
File remoting/remoting_options.gni:
Patch Set #1, Line 12:
is_chromeos_lacros'enable_me2me_host' will lead to a lot of extra compilation for lacros as this component doesn't ship with the browser (it is a standalone exe on Linux and N/A for any chromeos variant).
As in the previous comment, this may be expected but I wanted to call it out as it's not clear to me if this is required for the future processing steps (e.g. reverting back to !is_chromeos in the future).
To view, visit change 2532483. To unsubscribe, or for help writing mail filters, visit settings.
Yuta Hijikata (Gerrit)
Attention is currently required from: Joe Downing.
2 comments:
File remoting/BUILD.gn:
Patch Set #1, Line 180:
!is_chromeos_ash
Based on the doc link in the cl description, this statement will eventually return back to '!is_chro […]
Yes, once the intermediate steps have been complete, we will review is_chromeos_ash|lacros and make changes to them if necessary.
I will add a TODO comment to the two places you've pointed out.
File remoting/remoting_options.gni:
Patch Set #1, Line 12:
is_chromeos_lacros
'enable_me2me_host' will lead to a lot of extra compilation for lacros as this component doesn't shi […]
Ack
To view, visit change 2532483. To unsubscribe, or for help writing mail filters, visit settings.
Joe Downing (Gerrit)
Attention is currently required from: Yuta Hijikata.
Patch set 2:Code-Review +1
1 comment:
Patchset:
Thanks for doing this!
FYI, our team will likely start working on LaCrOS ~Q1 2021, I'll make sure to sync up with you if we are getting started and this migration hasn't completed yet.
To view, visit change 2532483. To unsubscribe, or for help writing mail filters, visit settings.
Yuta Hijikata (Gerrit)
Patch set 2:Commit-Queue +2
1 comment:
File remoting/BUILD.gn:
Patch Set #1, Line 180:
!is_chromeos_ash
Yes, once the intermediate steps have been complete, we will review is_chromeos_ash|lacros and make […]
Done
To view, visit change 2532483. To unsubscribe, or for help writing mail filters, visit settings.
Commit Bot (Gerrit)
Commit Bot submitted this change.
LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH)
The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).
The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.
Bug: 1052397
Change-Id: I81b77f364e2ec068bc00d0e103ff50bb54d44e15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532483
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuta Hijikata <yth...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829097}
---
M remoting/BUILD.gn
M remoting/base/BUILD.gn
M remoting/base/chromoting_event.cc
M remoting/client/BUILD.gn
M remoting/client/ui/BUILD.gn
M remoting/host/BUILD.gn
M remoting/host/chromeos/BUILD.gn
M remoting/host/chromeos/aura_desktop_capturer.cc
M remoting/host/chromoting_host_context.cc
M remoting/host/chromoting_host_context.h
M remoting/host/desktop_capturer_proxy.cc
M remoting/host/file_transfer/BUILD.gn
M remoting/host/heartbeat_sender.cc
M remoting/host/heartbeat_sender_unittest.cc
M remoting/host/host_details.cc
M remoting/host/input_injector_x11.cc
M remoting/host/input_monitor/BUILD.gn
M remoting/host/it2me/BUILD.gn
M remoting/host/it2me/it2me_host.cc
M remoting/host/it2me/it2me_host_unittest.cc
M remoting/host/it2me/it2me_native_messaging_host.cc
M remoting/host/it2me/it2me_native_messaging_host.h
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc
M remoting/host/linux/BUILD.gn
M remoting/host/mouse_cursor_monitor_proxy.cc
M remoting/host/policy_watcher.cc
M remoting/host/policy_watcher_unittest.cc
M remoting/host/server_log_entry_host_unittest.cc
M remoting/host/setup/me2me_native_messaging_host_main.cc
M remoting/protocol/BUILD.gn
M remoting/protocol/remoting_ice_config_request.cc
M remoting/remoting_locales.gni
M remoting/remoting_options.gni
M remoting/signaling/BUILD.gn
M remoting/signaling/ftl_host_device_id_provider.cc
M remoting/test/BUILD.gn
36 files changed, 141 insertions(+), 88 deletions(-)