Change use of SetBE32 / GetBE32 to take ArrayView [chromium/src : main]

0 views
Skip to first unread message

Harald Alvestrand (Gerrit)

unread,
Feb 17, 2026, 4:34:52 PM (4 days ago) Feb 17
to Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Lambros Lambrou

Harald Alvestrand voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lambros Lambrou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71b48d1533c7a3e7494424ff98639e6c0131aee7
Gerrit-Change-Number: 7585873
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Attention: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Feb 2026 21:34:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lambros Lambrou (Gerrit)

unread,
Feb 17, 2026, 4:39:49 PM (4 days ago) Feb 17
to Harald Alvestrand, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Harald Alvestrand

Lambros Lambrou voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Harald Alvestrand
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71b48d1533c7a3e7494424ff98639e6c0131aee7
Gerrit-Change-Number: 7585873
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Feb 2026 21:39:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 17, 2026, 5:56:11 PM (4 days ago) Feb 17
to Harald Alvestrand, Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Change use of SetBE32 / GetBE32 to take ArrayView

The API for those functions is being changed to provide greater
buffer safety, so callers need to change this.
Bug: webrtc:484070270
Change-Id: I71b48d1533c7a3e7494424ff98639e6c0131aee7
Commit-Queue: Harald Alvestrand <h...@chromium.org>
Auto-Submit: Harald Alvestrand <h...@chromium.org>
Commit-Queue: Lambros Lambrou <lambros...@chromium.org>
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1586027}
Files:
  • M remoting/protocol/message_decoder.cc
  • M remoting/protocol/message_reader_unittest.cc
  • M remoting/protocol/message_serialization.cc
Change size: S
Delta: 3 files changed, 7 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lambros Lambrou
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71b48d1533c7a3e7494424ff98639e6c0131aee7
Gerrit-Change-Number: 7585873
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages