remoting: Yak shaving for migrate-host implementation [chromium/src : main]
Yuwei Huang (Gerrit)
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing added 1 comment![]( "Open in Gerrit")
PTAL thanks!
It looks like you didn't add a reviewer, would you like Lambros or me to review?
Related details
- Yuwei Huang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Oops! I was meant to add you as the reviewer 😂
Related details
- Joe Downing
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Code-Review | +1 |
1 comment
{"single-process", kSingleProcess.get()},
{"gdm-managed", kGdmManaged.get()},nit: Feel free to Ack or address in a follow-up. I'm wondering if single-process is descriptive enough as maybe we have a host flavor in the future that is also single-process but not per-user. Maybe we should call it something like 'legacy-x11' and effectively snapshot that impl for DEs like XFCE4. Then if we add support for other DEs, we might add something like 'kde-managed' for example. WDYT?
Related details
- Yuwei Huang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Yuwei Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +2 |
2 comments
Thanks! CCing Lambros in case he has a different thought regarding host type naming and such.
{"single-process", kSingleProcess.get()},
{"gdm-managed", kGdmManaged.get()},nit: Feel free to Ack or address in a follow-up. I'm wondering if single-process is descriptive enough as maybe we have a host flavor in the future that is also single-process but not per-user. Maybe we should call it something like 'legacy-x11' and effectively snapshot that impl for DEs like XFCE4. Then if we add support for other DEs, we might add something like 'kde-managed' for example. WDYT?
Ack for now, but this map is easy to change anyway.
My gut feeling is that we are not going to evolve the single-process code and everything should be moved to multi-process. I'm planning to introduce X11 session support in multi-process, and multi-user should probably be done with host sharing in the directory, if we ever want to support that.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
remoting: Yak shaving for migrate-host implementation
Split off this CL to make things more focusable.
- Move SetupMultiProcessPairingRegistry to PairingRegistryDelegateLinux
so that it can be reused in the migrate-host binary.
- Exposing config paths in DaemonControllerDelegateLinuxMultiProcess
and DaemonControllerDelegateLinuxSingleProcess as public static
methods, allowing migrate-host to access them.
- Introduce HostType interface and implementations to represent
and describe different host architectures on Linux. This will also be
used by the start-host binary in the future.
- Move migrate_host_main.cc to its own build target to break circular
references.
- M remoting/host/BUILD.gn
- M remoting/host/daemon_process_linux.cc
- M remoting/host/linux/BUILD.gn
- A remoting/host/linux/host_types.cc
- A remoting/host/linux/host_types.h
- M remoting/host/pairing_registry_delegate_linux.cc
- M remoting/host/pairing_registry_delegate_linux.h
- M remoting/host/setup/daemon_controller_delegate_linux_multi_process.cc
- M remoting/host/setup/daemon_controller_delegate_linux_multi_process.h
- M remoting/host/setup/daemon_controller_delegate_linux_single_process.cc
- M remoting/host/setup/daemon_controller_delegate_linux_single_process.h
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |