Move common signaling/jingle data structures to /signaling [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Feb 17, 2026, 3:52:39 PM (4 days ago) Feb 17
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 17, 2026, 4:10:38 PM (4 days ago) Feb 17
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/signaling/jingle_data_structures_unittest.cc
Line 260, Patchset 12 (Latest):
const char* kTestSessionAcceptMessage =Yuwei Huang . unresolved
How long do you plan to keep the XML stuff around? If they will be around for a while then maybe wrap these with `// clang-format off` and `// clang-format on`, since clang-format seems to make these less readable.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 17, 2026, 5:35:08 PM (4 days ago) Feb 17
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Joe Downing . resolved
Thanks!
File remoting/signaling/jingle_data_structures_unittest.cc
Line 260, Patchset 12 (Latest):
const char* kTestSessionAcceptMessage =Yuwei Huang . resolved
How long do you plan to keep the XML stuff around? If they will be around for a while then maybe wrap these with `// clang-format off` and `// clang-format on`, since clang-format seems to make these less readable.
Joe Downing
We'll need to keep a subset of the XML stuff around for 6-12 months for ChromeOS back compat so I'll apply this in a follow-up CL.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 17, 2026, 5:39:15 PM (4 days ago) Feb 17
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move common signaling/jingle data structures to /signaling
This CL moves the common jingle message data structures from /protocol
to /signaling and fixes the namespace. This move is needed because
the conversion (XML/proto <-> struct) code will need to live in
/signaling but /protocol depends on /signaling and I want to avoid
a circular dependency.
I also renamed jingle_messages to jing_data_structures so the IPC
presubmit checks were not triggered, it looks like anything called
*_messages is considered an IPC message which is not true in this
case but it seemed easier to just rename the files.
As a side note, this CL is a little larger than needed since I also
moved ContentDescription which appears to be Chromotocol specific, I
am going to work on cleaning stuff like this up before the next CL.
Bug: 359620500
Change-Id: I6fe7635eacd92f52bfe977f44a4518c581a12fb1
Bypass-Check-License: Files moved, not added
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1586017}
Files:
- M remoting/client/common/frame_consumer_wrapper.cc
- M remoting/client/common/frame_consumer_wrapper.h
- M remoting/client/common/remoting_client.cc
- M remoting/codec/BUILD.gn
- M remoting/codec/DEPS
- M remoting/codec/audio_decoder.cc
- M remoting/codec/audio_decoder.h
- M remoting/codec/video_encoder.cc
- M remoting/codec/video_encoder.h
- M remoting/host/chromoting_host.cc
- M remoting/host/chromoting_host_unittest.cc
- M remoting/host/client_session.cc
- M remoting/host/client_session_unittest.cc
- M remoting/host/host_experiment_session_plugin.cc
- M remoting/host/host_experiment_session_plugin.h
- M remoting/host/host_experiment_session_plugin_unittest.cc
- M remoting/host/it2me/it2me_host.cc
- M remoting/host/pam_authorization_factory_posix.cc
- M remoting/host/remoting_me2me_host.cc
- M remoting/protocol/BUILD.gn
- M remoting/protocol/OWNERS
- M remoting/protocol/audio_decode_scheduler.cc
- M remoting/protocol/audio_decode_scheduler.h
- M remoting/protocol/audio_decode_scheduler_unittest.cc
- M remoting/protocol/audio_reader.cc
- M remoting/protocol/audio_writer.cc
- M remoting/protocol/audio_writer.h
- M remoting/protocol/authenticator.h
- M remoting/protocol/connection_to_host.h
- D remoting/protocol/content_description.h
- M remoting/protocol/fake_connection_to_host.cc
- M remoting/protocol/fake_connection_to_host.h
- M remoting/protocol/fake_session.cc
- M remoting/protocol/fake_session.h
- M remoting/protocol/ice_connection_to_client.cc
- M remoting/protocol/ice_connection_to_host.h
- M remoting/protocol/ice_transport.cc
- M remoting/protocol/ice_transport.h
- M remoting/protocol/ice_transport_unittest.cc
- M remoting/protocol/jingle_session.cc
- M remoting/protocol/jingle_session.h
- M remoting/protocol/jingle_session_manager.cc
- M remoting/protocol/jingle_session_manager.h
- M remoting/protocol/jingle_session_unittest.cc
- M remoting/protocol/session.h
- M remoting/protocol/session_plugin.h
- M remoting/protocol/transport.h
- M remoting/protocol/video_renderer.h
- M remoting/protocol/webrtc_connection_to_host.h
- M remoting/protocol/webrtc_transport_unittest.cc
- M remoting/signaling/BUILD.gn
- R remoting/signaling/content_description.cc
- A remoting/signaling/content_description.h
- R remoting/signaling/content_description_unittest.cc
- R remoting/signaling/jingle_data_structures.cc
- R remoting/signaling/jingle_data_structures.h
- R remoting/signaling/jingle_data_structures_unittest.cc
- R remoting/signaling/jingle_message_xml_converter.cc
- R remoting/signaling/jingle_message_xml_converter.h
- R remoting/signaling/session_config.cc
- R remoting/signaling/session_config.h
- R remoting/signaling/session_config_unittest.cc
- M remoting/test/BUILD.gn
- M remoting/test/it2me_standalone_host.cc
- M remoting/test/it2me_standalone_host.h
Change size: L
Delta: 65 files changed, 297 insertions(+), 306 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages