remoting: Implement host migration tool for Linux [chromium/src : main]
Yuwei Huang (Gerrit)
Yuwei Huang added 1 comment![]( "Open in Gerrit")
if (int exit_code = DisableService("chrome-remote-desktop@" + user_name +Please fix this WARNING reported by autoreview issue finding: Because `!=` has higher precedence than `=`, this parses as `int exit_code = (DisableService(...) != 0)`. `exit_code` will be assigned a boolean `0` or `1` instead of the actual error code returned by `DisableService`, and this will always return `1` on failure instead of the true exit code.\n\nIt should be separated:\n```cpp\nint exit_code = DisableService(\n \"chrome-remote-desktop@\" + user_name + \".service\");\nif (exit_code != 0) {\n return exit_code;\n}\n```
Because `!=` has higher precedence than `=`, this parses as `int exit_code = (DisableService(...) != 0)`. `exit_code` will be assigned a boolean `0` or `1` instead of the actual error code returned by `DisableService`, and this will always return `1` on failure instead of the true exit code.\n\nIt should be separated:\n```cpp\nint exit_code = DisableService(\n \"chrome-remote-desktop@\" + user_name + \".service\");\nif (exit_code != 0) {\n return exit_code;\n}\n```
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Related details
Code-Coverage
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |