updater: add WTL to DEPS, update to using WTL 10.1.0, delete git files [chromium/src : main]

0 views
Skip to first unread message

S Ganesh (Gerrit)

unread,
Apr 21, 2026, 3:15:05 PM (3 days ago) Apr 21
to Sorin Jianu, Gary Tong, Yuwei Huang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Gary Tong, Sorin Jianu and Yuwei Huang

S Ganesh voted and added 1 comment

Votes added by S Ganesh

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
S Ganesh . resolved

@gat...@chromium.org or @yuw...@chromium.org, could you please lgtm remoting/host/win/rdp_client_window.h, ty!

Open in Gerrit

Related details

Attention is currently required from:
  • Gary Tong
  • Sorin Jianu
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34d1933c8ee0f73ea0957fb996edd9daf76b69a4
Gerrit-Change-Number: 7782753
Gerrit-PatchSet: 4
Gerrit-Owner: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Sorin Jianu <so...@chromium.org>
Gerrit-Attention: Gary Tong <gat...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 19:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
Apr 21, 2026, 3:17:33 PM (3 days ago) Apr 21
to S Ganesh, Sorin Jianu, Gary Tong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Gary Tong, S Ganesh and Sorin Jianu

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Code-Review+1

1 comment

Patchset-level comments
Yuwei Huang . resolved

remoting/ LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Gary Tong
  • S Ganesh
  • Sorin Jianu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34d1933c8ee0f73ea0957fb996edd9daf76b69a4
Gerrit-Change-Number: 7782753
Gerrit-PatchSet: 4
Gerrit-Owner: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Sorin Jianu <so...@chromium.org>
Gerrit-Attention: S Ganesh <gan...@chromium.org>
Gerrit-Attention: Gary Tong <gat...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 19:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sorin Jianu (Gerrit)

unread,
Apr 21, 2026, 3:51:46 PM (3 days ago) Apr 21
to S Ganesh, Yuwei Huang, Gary Tong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Gary Tong and S Ganesh

Sorin Jianu voted and added 1 comment

Votes added by Sorin Jianu

Code-Review+1

1 comment

Patchset-level comments
Sorin Jianu . resolved

lgtm ty!

Open in Gerrit

Related details

Attention is currently required from:
  • Gary Tong
  • S Ganesh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34d1933c8ee0f73ea0957fb996edd9daf76b69a4
Gerrit-Change-Number: 7782753
Gerrit-PatchSet: 4
Gerrit-Owner: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: S Ganesh <gan...@chromium.org>
Gerrit-Attention: Gary Tong <gat...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 19:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

S Ganesh (Gerrit)

unread,
Apr 21, 2026, 4:17:40 PM (3 days ago) Apr 21
to Sorin Jianu, Yuwei Huang, Gary Tong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Gary Tong

S Ganesh voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Gary Tong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34d1933c8ee0f73ea0957fb996edd9daf76b69a4
Gerrit-Change-Number: 7782753
Gerrit-PatchSet: 4
Gerrit-Owner: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Gary Tong <gat...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 20:17:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 21, 2026, 4:22:04 PM (3 days ago) Apr 21
to S Ganesh, Sorin Jianu, Yuwei Huang, Gary Tong, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
updater: add WTL to DEPS, update to using WTL 10.1.0, delete git files

This is a follow-up change to crrev.com/c/7774483. WTL will now use the
CIPD files.
Bug: 502791521
Change-Id: I34d1933c8ee0f73ea0957fb996edd9daf76b69a4
Reviewed-by: Sorin Jianu <so...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: S Ganesh <gan...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618399}
Files:
  • M DEPS
  • M remoting/host/win/rdp_client_window.h
  • M third_party/wtl/README.chromium
  • D third_party/wtl/include/atlapp.h
  • D third_party/wtl/include/atlcrack.h
  • D third_party/wtl/include/atlctrls.h
  • D third_party/wtl/include/atlctrlw.h
  • D third_party/wtl/include/atlctrlx.h
  • D third_party/wtl/include/atlddx.h
  • D third_party/wtl/include/atldlgs.h
  • D third_party/wtl/include/atldwm.h
  • D third_party/wtl/include/atlfind.h
  • D third_party/wtl/include/atlframe.h
  • D third_party/wtl/include/atlgdi.h
  • D third_party/wtl/include/atlmisc.h
  • D third_party/wtl/include/atlprint.h
  • D third_party/wtl/include/atlres.h
  • D third_party/wtl/include/atlribbon.h
  • D third_party/wtl/include/atlscrl.h
  • D third_party/wtl/include/atlsplit.h
  • D third_party/wtl/include/atltheme.h
  • D third_party/wtl/include/atluser.h
  • D third_party/wtl/include/atlwinx.h
Change size: XL
Delta: 23 files changed, 19 insertions(+), 49697 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sorin Jianu, +1 by Yuwei Huang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34d1933c8ee0f73ea0957fb996edd9daf76b69a4
Gerrit-Change-Number: 7782753
Gerrit-PatchSet: 5
Gerrit-Owner: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages