Update MAGI protocol to support faster builds [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
May 20, 2026, 4:28:19 PM (yesterday) May 20
to Yuwei Huang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
May 20, 2026, 4:49:27 PM (yesterday) May 20
to Joe Downing, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
Patchset-level comments
Yuwei Huang . resolved
FWIW I wrote this in the root `GEMINI.md` file:
```
When building targets, use `out/debug` as the output directory.
```
Any I've never run into issues with the agent choosing the wrong directory.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 20, 2026, 4:50:14 PM (yesterday) May 20
to Yuwei Huang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 20, 2026, 6:31:17 PM (24 hours ago) May 20
to Joe Downing, Yuwei Huang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update MAGI protocol to support faster builds
When running MAGI, it often chooses an out directory like
out/Default. It does not check whether that dir is configured
to build locally or in a distributed fashion. This CL fixes
that problem and adds some logic so the scoping agent looks
for the output dir to use and prompts the user if it isn't
sure.
Change-Id: Ifca78780a5ee39b17271e1f7a3b55c0fc69c27a6
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633874}
Files:
- M remoting/tools/magi-mode/EXAMPLES.md
- M remoting/tools/magi-mode/SKILL.md
- M remoting/tools/magi-mode/magi_schema.json
- M remoting/tools/magi-mode/personas/core/scoping.json
- M remoting/tools/magi-mode/personas/infra/chromium_build.json
- M remoting/tools/magi-mode/tests/magi_stage_refine_tests.json
- M remoting/tools/magi-mode/tests/testdata/project.magi.json
Change size: M
Delta: 7 files changed, 38 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages