Lynne Jiang (Gerrit)

unread,

Jun 18, 2026, 1:41:20 PM (10 days ago) Jun 18

to Reilly Grant, Boris Sazonov, Lei Zhang, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Boris Sazonov, Joe Downing, Lei Zhang, Lynne Jiang and Reilly Grant

Lynne Jiang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Joe Downing
Lei Zhang
Lynne Jiang
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Jun 18, 2026, 1:46:47 PM (10 days ago) Jun 18

to Lynne Jiang, Reilly Grant, Boris Sazonov, Lei Zhang, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Boris Sazonov, Joe Downing, Lei Zhang and Lynne Jiang

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Reilly Grant . resolved

LGTM

File remoting/host/installer/linux/installer.include

Line 233, Patchset 2 (Latest): # LiteRt WebGPU Accelerator

Reilly Grant . unresolved

```suggestion
  # LiteRT WebGPU Accelerator
```

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Joe Downing
Lei Zhang
Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jun 18, 2026, 2:04:50 PM (10 days ago) Jun 18

to Lynne Jiang, Reilly Grant, Boris Sazonov, Lei Zhang, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Boris Sazonov, Joe Downing and Lynne Jiang

Lei Zhang added 4 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Lei Zhang . unresolved

Got red bots...

Commit Message

Line 7, Patchset 2 (Latest):[LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux.

Lei Zhang . unresolved

Why does this library use a different naming convention compared to liboptimization_guide_internal.so?

File chrome/installer/linux/BUILD.gn

Line 504, Patchset 2 (Latest): ":strip_ml_drift_webgpu_accelerator",

Lei Zhang . unresolved

sort - please remember to run `git cl format`.

File remoting/host/installer/linux/installer.include

Line 240, Patchset 2 (Latest): # Optimization Guide Internal

Lei Zhang . unresolved

This is here because crrev.com/961286 added it to chrome/installer/linux/common/installer.include and that file got cloned to //remoting. Taking a step back... does the remoting package need these files?

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Joe Downing
Lynne Jiang

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jun 18, 2026, 2:12:14 PM (10 days ago) Jun 18

to Lynne Jiang, Reilly Grant, Boris Sazonov, Lei Zhang, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Boris Sazonov, Joe Downing and Lynne Jiang

Lei Zhang added 1 comment

File chrome/installer/linux/BUILD.gn

Line 504, Patchset 2 (Latest): ":strip_ml_drift_webgpu_accelerator",

Lei Zhang . unresolved

sort - please remember to run `git cl format`.

Lei Zhang

https://ci.chromium.org/ui/p/chromium/builders/try/linux-presubmit/476274/overview for this CL says:

```
** Presubmit Warnings: 1 **
The src directory requires source formatting.
chrome/installer/linux/BUILD.gn

The following command may be able to fix some errors, while others may need to be fixed manually:
  git cl format 
Alternatively, if you are in Cider G, please use the "Format Modified Lines in All Files (git cl format)" functionality in the command palette.
```

Please consider adjusting your workflow so your CL uploads trigger presubmit checks.

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Downing (Gerrit)

unread,

Jun 18, 2026, 3:18:18 PM (10 days ago) Jun 18

to Lynne Jiang, Reilly Grant, Boris Sazonov, Lei Zhang, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Boris Sazonov and Lynne Jiang

Joe Downing added 1 comment

File remoting/host/installer/linux/installer.include

Line 240, Patchset 2 (Latest): # Optimization Guide Internal

Lei Zhang . unresolved

This is here because crrev.com/961286 added it to chrome/installer/linux/common/installer.include and that file got cloned to //remoting. Taking a step back... does the remoting package need these files?

Joe Downing

We don't rely on WebGPU for any product features but build relationships can be convoluted so it may appear that we do. Feel free to remove or keep (with a TODO to remove later) as needed.

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Lynne Jiang

satisfied_requirement

unsatisfied_requirement

open

diffy

Boris Sazonov (Gerrit)

unread,

Jun 19, 2026, 3:54:14 AM (10 days ago) Jun 19

to Lynne Jiang, Reilly Grant, Lei Zhang, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org, Boris Sazonov

Attention needed from Lynne Jiang

Boris Sazonov added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Boris Sazonov . resolved

Deferring to Lei.

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jun 22, 2026, 2:34:11 PM (6 days ago) Jun 22

to Reilly Grant, Lei Zhang, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Joe Downing and Lei Zhang

Lynne Jiang added 5 comments

Patchset-level comments

File-level comment, Patchset 2:

Lei Zhang . resolved

Got red bots...

Lynne Jiang

Fixed.

Commit Message

Line 7, Patchset 2:[LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux.

Lei Zhang . resolved

Why does this library use a different naming convention compared to liboptimization_guide_internal.so?

Lynne Jiang

It's required by LiteRT.

File chrome/installer/linux/BUILD.gn

Line 504, Patchset 2: ":strip_ml_drift_webgpu_accelerator",

Lei Zhang . resolved

sort - please remember to run `git cl format`.

Lei Zhang

https://ci.chromium.org/ui/p/chromium/builders/try/linux-presubmit/476274/overview for this CL says:
```
** Presubmit Warnings: 1 **
The src directory requires source formatting.
chrome/installer/linux/BUILD.gn
The following command may be able to fix some errors, while others may need to be fixed manually:
  git cl format 
Alternatively, if you are in Cider G, please use the "Format Modified Lines in All Files (git cl format)" functionality in the command palette.
```
Please consider adjusting your workflow so your CL uploads trigger presubmit checks.

Lynne Jiang

Done

File remoting/host/installer/linux/installer.include

Line 233, Patchset 2: # LiteRt WebGPU Accelerator

Reilly Grant . resolved

```suggestion
  # LiteRT WebGPU Accelerator
```

Lynne Jiang

Fix applied.

Line 240, Patchset 2: # Optimization Guide Internal

Lei Zhang . resolved

This is here because crrev.com/961286 added it to chrome/installer/linux/common/installer.include and that file got cloned to //remoting. Taking a step back... does the remoting package need these files?

Joe Downing

We don't rely on WebGPU for any product features but build relationships can be convoluted so it may appear that we do. Feel free to remove or keep (with a TODO to remove later) as needed.

Lynne Jiang

Left a TODO.

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jun 22, 2026, 2:49:27 PM (6 days ago) Jun 22

to Lynne Jiang, Lei Zhang, Reilly Grant, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Joe Downing and Lynne Jiang

Lei Zhang voted and added 5 comments

Votes added by Lei Zhang

Code-Review

+1

5 comments

Commit Message

Line 10, Patchset 3 (Latest):if(enable_ml_internal):

Lei Zhang . unresolved

nit: space after "if"

Line 11, Patchset 3 (Latest): - lite_rt_web_gpu_accelerator_symbols in chrome/BUILD.gn

Lei Zhang . unresolved

Please wrap at 72 columns.

Line 15, Patchset 3 (Latest):Bug: 525135572

Lei Zhang . unresolved

Add 525478189 as well.

File chrome/BUILD.gn

Line 1800, Patchset 3 (Latest): extract_symbols("lite_rt_web_gpu_accelerator_symbols") {

Lei Zhang . unresolved

Nest this after line 1825 to be consistent with line 1703-1705.

File chrome/installer/linux/BUILD.gn

Line 261, Patchset 3 (Latest): strip_binary("strip_ml_drift_webgpu_accelerator") {

Lei Zhang . unresolved

Nest after line 258.

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jun 22, 2026, 3:29:58 PM (6 days ago) Jun 22

to Lambros Lambrou, Lei Zhang, Reilly Grant, Joe Downing, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Joe Downing

Lynne Jiang added 5 comments

Commit Message

Line 10, Patchset 3:if(enable_ml_internal):

Lei Zhang . resolved

nit: space after "if"

Lynne Jiang

Done

Line 11, Patchset 3: - lite_rt_web_gpu_accelerator_symbols in chrome/BUILD.gn

Lei Zhang . resolved

Please wrap at 72 columns.

Lynne Jiang

Done

Line 15, Patchset 3:Bug: 525135572

Lei Zhang . resolved

Add 525478189 as well.

Lynne Jiang

Done

File chrome/BUILD.gn

Line 1800, Patchset 3: extract_symbols("lite_rt_web_gpu_accelerator_symbols") {

Lei Zhang . resolved

Nest this after line 1825 to be consistent with line 1703-1705.

Lynne Jiang

Done

File chrome/installer/linux/BUILD.gn

Line 261, Patchset 3: strip_binary("strip_ml_drift_webgpu_accelerator") {

Lei Zhang . resolved

Nest after line 258.

Lynne Jiang

Done

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Jun 23, 2026, 7:49:00 PM (5 days ago) Jun 23

to Lynne Jiang, Yuwei Huang, Joe Downing, Lei Zhang, Reilly Grant, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Joe Downing, Lynne Jiang and Yuwei Huang

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Lambros Lambrou . resolved

remoting LGTM, although the remoting changes in patchset #4 don't seem related to the rest of the CL. I think that file was copied from Chrome's build system and it probably has things we don't need for remoting 😊

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Lynne Jiang
Yuwei Huang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Yuwei Huang (Gerrit)

unread,

Jun 23, 2026, 7:50:18 PM (5 days ago) Jun 23

to Lynne Jiang, Lambros Lambrou, Joe Downing, Lei Zhang, Reilly Grant, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Joe Downing and Lynne Jiang

Yuwei Huang voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Lynne Jiang

satisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jun 23, 2026, 8:07:07 PM (5 days ago) Jun 23

to Yuwei Huang, Lambros Lambrou, Joe Downing, Lei Zhang, Reilly Grant, Chromium LUCI CQ, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Attention needed from Joe Downing

Lynne Jiang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 23, 2026, 9:01:51 PM (5 days ago) Jun 23

to Lynne Jiang, Yuwei Huang, Lambros Lambrou, Joe Downing, Lei Zhang, Reilly Grant, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux.

This CL gates the following targets and packaging files with:

if (enable_ml_internal):
    - lite_rt_web_gpu_accelerator_symbols in chrome/BUILD.gn
    - strip_ml_drift_webgpu_accelerator in
      chrome/installer/linux/BUILD.gn
    - libLiteRtWebGpuAccelerator.so packaging in
      chrome/installer/linux/BUILD.gn

Bug: 525135572,525478189

Change-Id: I7e7b831b64a9af8081af35ba6a9da57d8e162415

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7959041

Reviewed-by: Lambros Lambrou <lambros...@chromium.org>

Reviewed-by: Yuwei Huang <yuw...@chromium.org>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Commit-Queue: Lynne Jiang <lyj...@google.com>

Reviewed-by: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1651420}

Files:

M chrome/BUILD.gn
M chrome/installer/linux/BUILD.gn
M chrome/installer/linux/common/installer.py
M remoting/host/installer/linux/installer.include

Change size: S

Delta: 4 files changed, 42 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang, +1 by Yuwei Huang, +1 by Reilly Grant, +1 by Lambros Lambrou

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Fumitoshi Ukai (Gerrit)

unread,

Jun 23, 2026, 10:54:03 PM (5 days ago) Jun 23

to Chromium LUCI CQ, Lynne Jiang, Fumitoshi Ukai, Yuwei Huang, Lambros Lambrou, Joe Downing, Lei Zhang, Reilly Grant, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Fumitoshi Ukai added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Fumitoshi Ukai . resolved

break internal builder?
https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-rel-cog-cache-warmer/73029/overview

```
ERROR Input to targets not generated by a dependency.
The file:
  //out/9d6d-linux-chrome-re/libLiteRtWebGpuAccelerator.so
is listed as an input or source for the targets:
  //chrome/installer/linux:strip_ml_drift_webgpu_accelerator
  //chrome/installer/linux:calculate_deb_dependencies
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:canary_deb
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:canary_rpm
  //chrome/installer/linux:calculate_rpm_dependencies
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:stable_rpm
but this file was not generated by any dependencies of the targets. The target
that generates the file is:
  //components/optimization_guide/internal/third_party/odml:ml_drift_webgpu_accelerator_so

If you have generated inputs, there needs to be a dependency path between the
two targets in addition to just listing the files. For indirect dependencies,
the intermediate ones must be public_deps. data_deps don't count since they're
only runtime dependencies. If you think a dependency chain exists, it might be
because the chain is private. Try "gn path" to analyze.
GN gen failed: 1
```

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Taiyo Mizuhashi (Gerrit)

unread,

Jun 23, 2026, 11:09:43 PM (5 days ago) Jun 23

to Chromium LUCI CQ, Lynne Jiang, Fumitoshi Ukai, Yuwei Huang, Lambros Lambrou, Joe Downing, Lei Zhang, Reilly Grant, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Taiyo Mizuhashi has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jun 23, 2026, 11:10:57 PM (5 days ago) Jun 23

to Chromium LUCI CQ, Lynne Jiang, Fumitoshi Ukai, Yuwei Huang, Lambros Lambrou, Joe Downing, Lei Zhang, Reilly Grant, Michael Moss, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, chromotin...@chromium.org

Nathan Memmott has created a revert of this change

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux. [chromium/src : main]

Lynne Jiang (Gerrit)

Lynne Jiang voted Commit-Queue+1

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

2 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang added 4 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Joe Downing (Gerrit)

Joe Downing added 1 comment

Related details

Boris Sazonov (Gerrit)

Boris Sazonov added 1 comment

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 5 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 5 comments

Votes added by Lei Zhang

5 comments

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 5 comments

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

1 comment

Related details

Yuwei Huang (Gerrit)

Yuwei Huang voted Code-Review+1

Related details

Lynne Jiang (Gerrit)

Lynne Jiang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Fumitoshi Ukai (Gerrit)

Fumitoshi Ukai added 1 comment

Related details

Taiyo Mizuhashi (Gerrit)

Taiyo Mizuhashi has created a revert of this change

Related details

Nathan Memmott (Gerrit)

Nathan Memmott has created a revert of this change