Don't use deprecated net callbacks and modernize remoting/protocol [chromium/src : main]
0 views
Skip to first unread message
Avi Drissman (Gerrit)
Jan 12, 2026, 5:38:41 PM (8 days ago) Jan 12
to Avi Drissman, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Lambros Lambrou
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lambros Lambrou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jan 12, 2026, 6:01:06 PM (8 days ago) Jan 12
to Avi Drissman, Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Avi Drissman and Yuwei Huang
Lambros Lambrou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lambros Lambrou . resolved
Yuwei, is this CL just affecting chromotocol code that you're about to delete?
I don't see any problems with the code changes. If this affects our current WebRTC code, I think I'd prefer to patch this locally and test it before landing.
Related details
Attention is currently required from:
- Avi Drissman
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jan 12, 2026, 6:49:34 PM (8 days ago) Jan 12
to Avi Drissman, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Avi Drissman
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yuwei Huang . resolved
This seems to be code that will soon be deleted (in M146). Let me patch this CL to verify that it doesn't break anything.
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jan 12, 2026, 7:00:39 PM (8 days ago) Jan 12
to Avi Drissman, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Avi Drissman
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
Patchset-level comments
Yuwei Huang . resolved
Patched this CL and verified that it didn't break anything.
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Jan 13, 2026, 11:19:42 AM (7 days ago) Jan 13
to Avi Drissman, Yuwei Huang, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Avi Drissman voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 13, 2026, 11:26:03 AM (7 days ago) Jan 13
to Avi Drissman, Yuwei Huang, Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Don't use deprecated net callbacks and modernize remoting/protocol
Bug: 471017624
Change-Id: I2a0b3142b435cc683e5001d18644dd21cfb3431e
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568437}
Files:
- M remoting/protocol/channel_multiplexer_unittest.cc
- M remoting/protocol/channel_socket_adapter.cc
- M remoting/protocol/channel_socket_adapter.h
- M remoting/protocol/channel_socket_adapter_unittest.cc
- M remoting/protocol/fake_datagram_socket.cc
- M remoting/protocol/fake_datagram_socket.h
- M remoting/protocol/p2p_datagram_socket.h
- M remoting/protocol/pseudotcp_adapter.cc
- M remoting/protocol/pseudotcp_adapter_unittest.cc
Change size: L
Delta: 9 files changed, 250 insertions(+), 199 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages