AV1 encoder wrapper tweaks for Chrome Remote Desktop [chromium/src : main]
Joe Downing (Gerrit)
Attention is currently required from: Lambros Lambrou.
1 comment:
Patchset:
PTAL!
To view, visit change 3687980. To unsubscribe, or for help writing mail filters, visit settings.
Marco Paniconi (Gerrit)
Attention is currently required from: Joe Downing, Lambros Lambrou.
4 comments:
File remoting/codec/webrtc_video_encoder_av1.cc:
Patch Set #1, Line 97:
error = aom_codec_control(codec.get(), AV1E_SET_ENABLE_TPL_MODEL, 0);These next 3 controls (line 97,99,101) are duplicated below (line 133,135,137), so they can be removed here. Sorry about that.
Patch Set #1, Line 139:
error = aom_codec_control(codec.get(), AV1E_SET_AQ_MODE, 3);prefer to move this AQ_MODE control higher up, after the CPUUSED control (line 70), since it's an important setting.
can you also add these settings, shouldn't change performance since some of these are off by default, or won't do anything in REALTIME build, but good to add anyway:
(- ,AV1E_SET_NOISE_SENSITIVITY, 0)
(-, AV1E_SET_ENABLE_PAETH_INTRA, 0
(- ,AV1E_SET_ENABLE_QM, 0);
(- ,AV1E_SET_ENABLE_RECT_PARTITIONS, 0);
(- ,AV1E_SET_ENABLE_RESTORATION, 0);
(- ,AV1E_SET_ENABLE_SMOOTH_INTERINTRA, 0);
(- ,AV1E_SET_ENABLE_TX64, 0);
(- ,AV1E_SET_MAX_REFERENCE_FRAMES, 3);Patch Set #1, Line 225:
config_.rc_overshoot_pct = 15;can you replace 224,225 and add 2 more:
cfg_.rc_undershoot_pct = 50;
cfg_.rc_overshoot_pct = 50;
cfg_.rc_buf_initial_sz = 600;
cfg_.rc_buf_optimal_sz = 600;
cfg_.rc_buf_sz = 1000;
To view, visit change 3687980. To unsubscribe, or for help writing mail filters, visit settings.
Joe Downing (Gerrit)
Attention is currently required from: Lambros Lambrou, Marco Paniconi.
Patch set 2:Commit-Queue +1
4 comments:
File remoting/codec/webrtc_video_encoder_av1.cc:
Patch Set #1, Line 97:
error = aom_codec_control(codec.get(), AV1E_SET_ENABLE_TPL_MODEL, 0);
These next 3 controls (line 97,99,101) are duplicated below (line 133,135,137), so they can be remov […]
Ugh, I should have checked for dupes, not your fault : )
Patch Set #1, Line 139:
error = aom_codec_control(codec.get(), AV1E_SET_AQ_MODE, 3);
prefer to move this AQ_MODE control higher up, after the CPUUSED control (line 70), since it's an im […]
Done
can you also add these settings, shouldn't change performance since some of these are off by default […]
Done
Patch Set #1, Line 225:
config_.rc_overshoot_pct = 15;
can you replace 224,225 and add 2 more: […]
Done
To view, visit change 3687980. To unsubscribe, or for help writing mail filters, visit settings.
Marco Paniconi (Gerrit)
Attention is currently required from: Joe Downing, Lambros Lambrou.
1 comment:
Patchset:
+1, encoder settings look good to me.
To view, visit change 3687980. To unsubscribe, or for help writing mail filters, visit settings.
Lambros Lambrou (Gerrit)
Attention is currently required from: Joe Downing.
Patch set 2:Code-Review +1
Joe Downing (Gerrit)
Patch set 2:Commit-Queue +2
1 comment:
Patchset:
Thanks!
To view, visit change 3687980. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
AV1 encoder wrapper tweaks for Chrome Remote Desktop
This CL sets a number of encoder parameters tht we suggested by the WebM
folks. Initial testing with these values indicates a ~2X increase in
framerate and makes the codec usable (though it still seems a tad slower
than VP9 in my initial testing). I've also removed a NOTIMPL log from the
encoding path as it is way too chatty when using AV1.
Change-Id: Ieccc2a2e2f96e94f6dd5137c5ccb22492da3c878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687980
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010661}
---
M remoting/codec/webrtc_video_encoder_av1.cc
M remoting/protocol/webrtc_video_encoder_wrapper.cc
2 files changed, 97 insertions(+), 15 deletions(-)