Improve DTD filter logic in SignalStrategy::ParseStanzaXml [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
May 20, 2026, 4:23:12 PM (yesterday) May 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
May 20, 2026, 4:46:47 PM (yesterday) May 20
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/signaling/xmpp_constants.h
Line 25, Patchset 3 (Latest):
extern const size_t kMaxStanzaSize;Yuwei Huang . unresolved
Please include `<cstddef>` in this header since you are using `size_t`. You might also want to change `size_t` to `std::size_t` (or the other way around) to be consistent with the definition in the `.cc` file.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 20, 2026, 4:49:50 PM (yesterday) May 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/signaling/xmpp_constants.h
Please include `<cstddef>` in this header since you are using `size_t`. You might also want to change `size_t` to `std::size_t` (or the other way around) to be consistent with the definition in the `.cc` file.
Joe Downing
Oh funny, I already did that but it looks like the CL didn't get uploaded. done!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 20, 2026, 7:02:19 PM (23 hours ago) May 20
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Improve DTD filter logic in SignalStrategy::ParseStanzaXml
Bug: 513138148
Change-Id: I6eaed5442d6fc73f406ce374f925b3fc8c37e863
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633889}
Files:
- M remoting/signaling/ftl_messaging_client.cc
- M remoting/signaling/ftl_messaging_client_unittest.cc
- M remoting/signaling/ftl_signal_strategy_unittest.cc
- M remoting/signaling/jingle_message_struct_converter.cc
- M remoting/signaling/jingle_message_struct_converter_unittest.cc
- M remoting/signaling/jingle_message_xml_converter.cc
- M remoting/signaling/jingle_message_xml_converter.h
- M remoting/signaling/jingle_message_xml_converter_unittest.cc
- M remoting/signaling/signal_strategy.cc
- M remoting/signaling/xmpp_constants.cc
- M remoting/signaling/xmpp_constants.h
Change size: M
Delta: 11 files changed, 190 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages